Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve specification of InteriorLights #531

Closed
jdacoello opened this issue Feb 7, 2023 · 2 comments
Closed

Improve specification of InteriorLights #531

jdacoello opened this issue Feb 7, 2023 · 2 comments

Comments

@jdacoello
Copy link
Contributor

jdacoello commented Feb 7, 2023 •
edited
Loading

LightIntensity as actuator

In vehicle_signal_specification/spec/Cabin/InteriorLights.vspec, LightIntensity is defined as sensor. Should it not be an actuator instead?

LightIntensity:
  datatype: uint8
  type: sensor
  unit: percent
  min: 0
  max: 100
  description: Intensity of the interior lights. 0 = Off. 100 = Full brightness.

Lights individually controlable

Right now the intensity is referring to all the interior lights.

Adding other aspects

For example:

  • Color for each light
  • Flex (decorative) lights
@erikbosch
Copy link
Collaborator

Meeting notes: Daniel to work on PR

@jdacoello jdacoello mentioned this issue Feb 14, 2023
Closed
@erikbosch
Copy link
Collaborator

Fixed by #587

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jdacoello @erikbosch