Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asynchronous return execution ID upon playbook trigger API #181

Closed
lucamrgs opened this issue Jul 16, 2024 · 2 comments · Fixed by #183
Closed

Asynchronous return execution ID upon playbook trigger API #181

lucamrgs opened this issue Jul 16, 2024 · 2 comments · Fixed by #183
Labels
enhancement New feature or request

Comments

@lucamrgs
Copy link
Collaborator

Problem: execution ID from trigger API call is returned only upon execution completed. This makes it not possible to query the Reporter by execution ID.

Solution: make trigger API call execution asynchronous and return execution ID

@lucamrgs lucamrgs added the enhancement New feature or request label Jul 16, 2024
@lucamrgs
Copy link
Collaborator Author

Method:

  • Two pull requests, one for async return exec id, one for solving race conditions on reporting via channel
  • No returns of error anymore from the execution as they're handled within reporting
  • Detach details object from decomposer property
  • Listen to channel in trigger api (as in internal/fin/protocol/awaitresultortimeout)
  • Safe race conditions via mutex

@lucamrgs
Copy link
Collaborator Author

I am using a public property for the trigger API channel in order to be able to test it

@lucamrgs lucamrgs linked a pull request Jul 23, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant