Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve playbook execution speed by embedding the json schema's #157

Closed
MaartendeKruijf opened this issue May 16, 2024 · 0 comments · Fixed by #199
Closed

Improve playbook execution speed by embedding the json schema's #157

MaartendeKruijf opened this issue May 16, 2024 · 0 comments · Fixed by #199
Labels
cacao OASIS cacao model related issue enhancement New feature or request

Comments

@MaartendeKruijf
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
The execution speed is heavily impacted by the download of the JSON schema's during execution.

Describe the solution you'd like
An option to fix this is to implement a golang embed schema for the JSON schema's

Describe alternatives you've considered
Alternatively one could put the schema into a source file

Additional context
https://pkg.go.dev/embed
@MaartendeKruijf MaartendeKruijf added enhancement New feature or request cacao OASIS cacao model related issue labels May 16, 2024
@MaartendeKruijf MaartendeKruijf linked a pull request Aug 2, 2024 that will close this issue
Feature/157 improve playbook execution speed by embedding the json schemas #199
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cacao OASIS cacao model related issue enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature/157 improve playbook execution speed by embedding the json schemas COSSAS/SOARCA
1 participant
@MaartendeKruijf