Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fin protocol accepts any ack #123

Open
xncz8h opened this issue Apr 8, 2024 · 0 comments
Open

Fin protocol accepts any ack #123

xncz8h opened this issue Apr 8, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@xncz8h
Copy link
Collaborator

xncz8h commented Apr 8, 2024

Observed Behaviour

When a fin capability command is send, while waiting for an Ack, there is no check to see if the returned Ack has the correct message_id.
This results in accepting any Ack. In the future this may lead to bugs when executing mulitple commands.

Expected Behaviour

Only accept Acks with correct message_id
@xncz8h xncz8h added the bug Something isn't working label Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@xncz8h