Skip to content

Commit a489295

Browse files
BCDA-8570 Upgrade github action artifact to v4 (#195)
## 🎫 Ticket https://jira.cms.gov/browse/BCDA-8570 ## 🛠 Changes Upgraded github actions artifact-(up|down)load to v4. ## ℹ️ Context v3 was deprecated as of Nov 30th. We were previously prevented upgrading to v4 due to dependencies on node. PLT-338 fixed that for us and has since been deployed. <!-- If any of the following security implications apply, this PR must not be merged without Stephen Walter's approval. Explain in this section and add @SJWalter11 as a reviewer. - Adds a new software dependency or dependencies. - Modifies or invalidates one or more of our security controls. - Stores or transmits data that was not stored or transmitted before. - Requires additional review of security implications for other reasons. --> ## 🧪 Validation Github actions workflows successfully passing as normal.
1 parent 6ea12cb commit a489295

File tree

1 file changed

+2
-5
lines changed

1 file changed

+2
-5
lines changed

.github/workflows/ci-workflow.yml

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ jobs:
3232
run: |
3333
make test
3434
- name: Archive code coverage results
35-
uses: actions/upload-artifact@v3
35+
uses: actions/upload-artifact@v4
3636
with:
3737
name: code-coverage-report
3838
path: ./test_results/latest/testcoverage.out
@@ -41,12 +41,9 @@ jobs:
4141
name: Sonarqube Quality Gate
4242
needs: build
4343
runs-on: self-hosted
44-
env:
45-
# Workaround until https://jira.cms.gov/browse/PLT-338 is implemented.
46-
ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION: "true"
4744
steps:
4845
- name: Download code coverage
49-
uses: actions/download-artifact@v3
46+
uses: actions/download-artifact@v4
5047
with:
5148
name: code-coverage-report
5249
- name: Set env vars from AWS params

0 commit comments

Comments
 (0)