Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore expired secrets named CWAP_AuthSecret if Azure Application Proxy is used. #3

Open
zimmermannb opened this issue Jan 14, 2025 · 2 comments

Comments

@zimmermannb
Copy link

Hi,

we are using that extension and it is working great, many thanks for that 👍👍.

We noticed something that could be impoved:

When an Application is published using the Azure-AD-Application-Proxy, three client secrets are created for the App-Registration, and usually one of them is expired. The Microsoft Documentation clearly states that this is expected and the expired secrets should not be deleted.
The CheckMK-Plugin does generate a warning for this situation, cause one of the secrets is expired.

It would be great if the Plugin would ignore the oldest secret named "CWAP_AuthSecret" as along as there are two more "CWAP_AuthSecrets" that are still valid.

Here are some more details for reference:

https://www.reddit.com/r/AZURE/comments/p9uk2d/azure_app_proxy_registration_expiring_client/

https://learn.microsoft.com/en-us/entra/identity/app-proxy/application-proxy-faq#can-i-modify-an-application-proxy-app-from-the---app-registrations---page-in-the-microsoft-entra-admin-center-

@CLiX-1
Copy link
Owner

CLiX-1 commented Jan 15, 2025

Thank you for your feedback!

There is another app with similar behavior. Microsoft creates an app registration for Power Virtual Agents (Bots) and each app has 4 auto managed certificates.

I think it would be the best to ignore these apps completely.

Actually you can disable the service with the rule „Disabled services“, but I will check if I can disable the discovery of these kinds of app registrations.
I think every Entra App Proxy app should have a tag „WindowsAzureActiveDirectoryOnPremApp“ and Power Virtual Agents should have a tag like „power-virtual-agents-“.

@zimmermannb
Copy link
Author

Yeah of course we can disable specific services but we do have ~1000 app-registrations, which makes it hard to select them individually. If the Services could get a Tag if they are a Bot or a Published App we could disable them based on a Rule.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants