-
Notifications
You must be signed in to change notification settings - Fork 1
Ignore expired secrets named CWAP_AuthSecret if Azure Application Proxy is used. #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Thank you for your feedback! There is another app with similar behavior. Microsoft creates an app registration for Power Virtual Agents (Bots) and each app has 4 auto managed certificates. I think it would be the best to ignore these apps completely. Actually you can disable the service with the rule „Disabled services“, but I will check if I can disable the discovery of these kinds of app registrations. |
Yeah of course we can disable specific services but we do have ~1000 app-registrations, which makes it hard to select them individually. If the Services could get a Tag if they are a Bot or a Published App we could disable them based on a Rule. |
I've uploaded a new version of the plugin (v1.2.1). Would you test the new version in your environment? I think with this option we have the most flexibility to exclude specific credentials or all like the Entra App Proxy secrets. |
We did update the Plugin and it is working partially. The dispalyName is read by CheckMK and also the Rule to filter for those does work. 👍👍 Unfortunately it did not work for our usecase as it turns out Azure is sometimes using the field "displayName" and sometimes the field "customKeyIdentifier" which has the displayName Base64-Encoded. So far I've identified 3 different cases.
Would it be be possible to also expose "customKeyIdentifer" to checkmk so we can also use those values within the rule? |
It looks like for certificates (keyCredentials) the customKeyIdentifier represents the thumbprint of the certificate, but not always. I saw a certificate with invalid data (Microsoft Assessments). The UI shows "Thumbprint not available". It looks like customKeyIdentifier and displayName are always filled with data. And for secrets (passwordCredentials) the customKeyIdentifier contains the description like the displayName. Please check out the new version 1.2.3. Thanks! |
Now it works perfectly and we are able to exclude CWAP_AuthSecret from the checks. Thans for providing the update. Really appreachiate your support. |
Hi,
we are using that extension and it is working great, many thanks for that 👍👍.
We noticed something that could be impoved:
When an Application is published using the Azure-AD-Application-Proxy, three client secrets are created for the App-Registration, and usually one of them is expired. The Microsoft Documentation clearly states that this is expected and the expired secrets should not be deleted.
The CheckMK-Plugin does generate a warning for this situation, cause one of the secrets is expired.
It would be great if the Plugin would ignore the oldest secret named "CWAP_AuthSecret" as along as there are two more "CWAP_AuthSecrets" that are still valid.
Here are some more details for reference:
https://www.reddit.com/r/AZURE/comments/p9uk2d/azure_app_proxy_registration_expiring_client/
https://learn.microsoft.com/en-us/entra/identity/app-proxy/application-proxy-faq#can-i-modify-an-application-proxy-app-from-the---app-registrations---page-in-the-microsoft-entra-admin-center-
The text was updated successfully, but these errors were encountered: