CausalTestResult test_value

[jmafoster1]

We have a field in CausalTestResult called test_value. Please can someone tell me what it is? Have we always had it? Looking at how it's used, it seems like redundancy for Estimator.treatment_value. If this is the case, can it be removed, or do we use it for something special?

[jmafoster1]

Along similar lines, I really don't think we should be passing Estimator objects into CausalTestResult objects, especially since we're only accessing particular properties. I think it would be much better to put those values directly in fields, or if pylint kicks off, we should have a data class or something.

[christopher-wild]

We have a field in CausalTestResult called test_value. Please can someone tell me what it is? Have we always had it? Looking at how it's used, it seems like redundancy for Estimator.treatment_value. If this is the case, can it be removed, or do we use it for something special?

The TestValue class was added in PR #119 which separated CausalTestResult from causal_test_outcome.py as well as other refactoring. It looks like it adds the capability to handle different value types, i.e. ate , risk-ratio, etc.

Is the test_value attribute the same thing as the Estimator.treatment_value? It comes from methods like estimator.estimate_unit_ate() and estimator.estimate_risk_ratio().

Not passing in the estimator objects and simplying it does seem like a logical thing to do