Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON unit tests improvements #190

Open
christopher-wild opened this issue May 22, 2023 · 0 comments
Open

JSON unit tests improvements #190

christopher-wild opened this issue May 22, 2023 · 0 comments

Comments

@christopher-wild
Copy link
Contributor

christopher-wild commented May 22, 2023

Is your feature request related to a problem? Please describe.
The current JSON Frontend unittests rely on the causal test failing for the unittest to pass.

Describe the solution you'd like
A basic casusal DAG and scenario to be made where we know what the test results will be and can test against them. I don't understand the underlying causal inference well enough to make this though.

Describe alternatives you've considered
N/A

Additional context
This would have the benefit of our tests being more accurate. I.e. if a test parameter is not being set correctly but the tests still run, we currently would not know as the tests will just fail as usual.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant