You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Perhaps we might want to reconsider the purpose of expected_causal_effect (implemented in CausalTestOutcome') and see if we can rework some aspects of this into there. I think it'd be quite reasonable to have a class to represent "we expect the outcome Y to Increase according to the ATE effect measure". That would cut three variables (outcome_variable, estimate_type, and effect) down to 1. As with AbstractCausalTestCase, we could also pass the effect modifiers directly into the estimator, as we do with the adjustment set. We should also stop unpacking the data class in the init` method!
causal_testing/testing/causal_test_case.py:24:4: R0913: Too many arguments (7/5) (too-many-arguments)
This would be solved by refactoring the above.
The text was updated successfully, but these errors were encountered:
causal_testing/testing/causal_test_case.py:12:0: R0902: Too many instance attributes (9/7) (too-many-instance-attributes)
Currently, we have
Perhaps we might want to reconsider the purpose of
expected_causal_effect
(implemented inCausalTestOutcome') and see if we can rework some aspects of this into there. I think it'd be quite reasonable to have a class to represent "we expect the outcome Y to Increase according to the ATE effect measure". That would cut three variables (
outcome_variable,
estimate_type, and
effect) down to 1. As with
AbstractCausalTestCase, we could also pass the effect modifiers directly into the estimator, as we do with the adjustment set. We should also stop unpacking the data class in the
init` method!causal_testing/testing/causal_test_case.py:24:4: R0913: Too many arguments (7/5) (too-many-arguments)
This would be solved by refactoring the above.
The text was updated successfully, but these errors were encountered: