Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose choice when there are multiple adjustment sets #101

Open
christopher-wild opened this issue Oct 31, 2022 · 1 comment
Open

Expose choice when there are multiple adjustment sets #101

christopher-wild opened this issue Oct 31, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@christopher-wild
Copy link
Contributor

Currently when multiple viable minimal_adjustment_sets are found, the smallest one is chosen programmatically.

There are reasons however for the user to consider another minimal_adjustment_set more suitable and may wish to have a choice between the different adjustment sets. One reason for example is there could be much better data for nodes of one adjustment set over another.

After a discussion with @jmafoster1 and @AndrewC19 on 25/10/22, it may be most appropriate to add two new parameters to the identification function or to the execute_test_suites function (to be decided).

The first parameter would be a flag to indicate that the code should be halted when multiple adjustment sets are found and displaying the multiple minimal_adjustment_sets. This would give the user chance to explore and decide which adjustment set is most appropriate.

The second parameter would be a mechanism for pre-selecting an adjustment set if the user already knew from previous executions which set was most appropriate.

@christopher-wild
Copy link
Contributor Author

also look at #58

@f-allian f-allian added the enhancement New feature or request label Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants