Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PMP: Add a function to find edges with smallest/largest dihedral angle #8676

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

afabri
Copy link
Member

@afabri afabri commented Jan 3, 2025

Summary of Changes

Add an overloaded of the function detect_sharp_edges() to identify the non-border edges with smallest/largest dihedral angle.
It returns the edge descriptors and the angles in degree.

  • Deal with non-triangle case
  • What to do with edges adjacent to degenerate faces?
  • Add to statistics in Lab
  • Small Feature

Release Management

  • Affected package(s): Polygon Mesh Processing
  • Issue(s) solved (if any): fix #0000, fix #0000,...
  • Feature/Small Feature (if any):
  • Link to compiled documentation (obligatory for small feature) wrong link name to be changed
  • License and copyright ownership: GeometryFactory

@afabri
Copy link
Member Author

afabri commented Jan 3, 2025

/build:v0

Copy link

github-actions bot commented Jan 3, 2025

There was an error while building the doc:

/home/runner/work/cgal/cgal/Polygon_mesh_processing/include/CGAL/Polygon_mesh_processing/detect_features.h:314: warning: argument 'angle_in_deg' of command @param is not found in the argument list of CGAL::Polygon_mesh_processing::detect_sharp_edges(const PolygonMesh &pmesh, const NamedParameters &np=parameters::default_values())
/home/runner/work/cgal/cgal/Polygon_mesh_processing/include/CGAL/Polygon_mesh_processing/detect_features.h:314: warning: argument 'edge_is_feature_map' of command @param is not found in the argument list of CGAL::Polygon_mesh_processing::detect_sharp_edges(const PolygonMesh &pmesh, const NamedParameters &np=parameters::default_values())

https://github.com/CGAL/cgal/actions/runs/12601154955

@afabri
Copy link
Member Author

afabri commented Jan 3, 2025

/force-build:v0

Copy link

github-actions bot commented Jan 3, 2025

The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/8676/v0/Manual/index.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant