Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

display measurements with respect to the users unit settings #24

Open
CFenner opened this issue Oct 11, 2016 · 5 comments
Open

display measurements with respect to the users unit settings #24

CFenner opened this issue Oct 11, 2016 · 5 comments

Comments

@CFenner
Copy link
Owner

CFenner commented Oct 11, 2016

see #23

@macogle
Copy link

macogle commented Jan 17, 2017

Christopher, in the discussion of issue #23, you mentioned that your understanding of the Weather API was that the data was being sent in the correct units. I believe the documentation provided in the introduction to the API contradicts that.

From the technical data provided in the introduction to the Weather Station API, it seems Netatmo is providing weather data in the following format:
screen shot 2017-01-16 at 5 49 58 pm

Netatmo users are provided with the following regional preference setting options from their browser (the settings are similar in the iOS/android apps):
screen shot 2017-01-16 at 5 46 00 pm

The 'user' parameter within the API gives the necessary data to correct the returned data within the application:
screen shot 2017-01-16 at 5 54 17 pm

I am very new to coding (esp. in Javascript) so please forgive any errors in syntax I may make. Is it feasible to build three arguments to implement these 'unit', 'windunit' and 'pressureunit' parameters in the "formatter" function?

@CFenner
Copy link
Owner Author

CFenner commented Aug 15, 2023

linked to #148

@CFenner
Copy link
Owner Author

CFenner commented Aug 15, 2023

We already get this from the station data API call:

Bildschirmfoto 2023-08-15 um 15 39 04

@CFenner CFenner mentioned this issue May 13, 2024
@y0m1g
Copy link
Contributor

y0m1g commented May 13, 2024

So the issue is NetAtmo's API always returns the measurement values in a specific set of units... but it also provides user units preferences so it can be converted afterwards, right?

It's indeed a weird implementation... but couldn't the preferences be fetched and stored when initiating the module, then simply convert the fetched measurement values, and display the proper units, based on that? Or something like that?
Is there any other part of information missing?

@CFenner
Copy link
Owner Author

CFenner commented Jun 24, 2024

@y0m1g @macogle: Thanks to @Duhlin12 the module now can change the wind unit, please test as I do not have such a unit.

@Laz2516 @GobleSt changing pressure & temp can be added easily once I figure out the how to transform the values.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants