Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

๐Ÿ”จ[Refactor] - ๋ฆฌํ”„๋ ˆ์‹œ ํ† ํฐ ๋ฐœ๊ธ‰ ๋กœ์ง ์ˆ˜์ • #185

Open
1 task done
suhhyun524 opened this issue Aug 12, 2024 · 0 comments ยท Fixed by #186

Comments

@suhhyun524
Copy link
Member

suhhyun524 commented Aug 12, 2024

๐Ÿ”จ Refactor - ๋ฆฌํ”„๋ ˆ์‹œ ํ† ํฐ ๋ฐœ๊ธ‰ ๋กœ์ง ์ˆ˜์ •

๐Ÿ“ Description


๊ธฐ์กด์—๋Š” ๋กœ๊ทธ์ธ id๋กœ ์‚ฌ์šฉ์ž๋ฅผ ๊ตฌ๋ถ„ํ•ด PC/๋ชจ๋ฐ”์ผ ๋™์‹œ ๋กœ๊ทธ์ธ์ด ๋ถˆ๊ฐ€๋Šฅํ•ฉ๋‹ˆ๋‹ค.
user-agent ํ—ค๋”๋ฅผ ํ•จ๊ป˜ ํ™•์ธํ•˜๊ณ  ํ† ํฐ์„ ๋ฐœ๊ธ‰ํ•˜์—ฌ ๋ฌธ์ œ๋ฅผ ์ˆ˜์ •ํ•˜๊ณ ์ž ํ•ฉ๋‹ˆ๋‹ค.

โœ… To Do List


  • ํ† ํฐ ๋ฐœ๊ธ‰ ๋กœ์ง ์ˆ˜์ •
hyunihs pushed a commit that referenced this issue Aug 14, 2024
* [refact] ๋ฆฌํ”„๋ ˆ์‹œํ† ํฐ ๋ฐœ๊ธ‰ ๋กœ์ง ์ˆ˜์ • #185

* [refact] ์ƒ์ˆ˜ ์ถ”๊ฐ€
hyunihs added a commit that referenced this issue Aug 14, 2024
* [feat] ์ง€์› ์„œ๋ฅ˜ ์‚ญ์ œ ๊ธฐ๋Šฅ (#177)

* [feat] ์ง€์› ์„œ๋ฅ˜ ์‚ญ์ œ

* [chore] update CODEOWNERS

* [feat] ์ง€์›์„œ ๋ชฉ๋ก ๋ณด๊ธฐ API required false์ธ parameter๋“ค์— ๋Œ€ํ•ด default value ์„ค์ •

* [test] ์ง€์›์„œ ๋ชฉ๋ก ๋ณด๊ธฐ API required false์ธ parameter๋“ค์— ๋Œ€ํ•œ ํ…Œ์ŠคํŠธ ์ฝ”๋“œ ์ž‘์„ฑ

* [feat] ์ง€์›์„œ ๋ชฉ๋ก ๋ณด๊ธฐ API enum ํƒ€์ž…์ธ parameter๋“ค์— ๋Œ€ํ•ด allowable values ์„ค์ •

* [test] ์ง€์›์„œ ๋ชฉ๋ก ๋ณด๊ธฐ API enum ํƒ€์ž…์ธ parameter๋“ค์— ๋Œ€ํ•ด ํ…Œ์ŠคํŠธ ์ฝ”๋“œ ์ž‘์„ฑ

* [fix] ์ง€์›์„œ ์—‘์…€ ํŒŒ์ผ ์ƒ์„ฑ ์‹œ๊ฐ API ํ…Œ์ŠคํŠธ status code ์ˆ˜์ •

* [revert] ์ฝ”๋“œ ์ˆ˜์ • ๋‚ด์—ญ ๋˜๋Œ๋ฆผ

* [feat] ์ง€์›์„œ ๋ชฉ๋ก ๋ณด๊ธฐ API required false์ธ parameter๋“ค์— ๋Œ€ํ•ด default value ์„ค์ •

* [test] ์ง€์›์„œ ๋ชฉ๋ก ๋ณด๊ธฐ API required false์ธ parameter๋“ค์— ๋Œ€ํ•œ ํ…Œ์ŠคํŠธ ์ฝ”๋“œ ์ž‘์„ฑ

* [feat] ์ง€์›์„œ ๋ชฉ๋ก ๋ณด๊ธฐ API enum ํƒ€์ž…์ธ parameter๋“ค์— ๋Œ€ํ•ด allowable values ์„ค์ •

* [test] ์ง€์›์„œ ๋ชฉ๋ก ๋ณด๊ธฐ API enum ํƒ€์ž…์ธ parameter๋“ค์— ๋Œ€ํ•ด ํ…Œ์ŠคํŠธ ์ฝ”๋“œ ์ž‘์„ฑ

* [fix] ์ง€์›์„œ ์—‘์…€ ํŒŒ์ผ ์ƒ์„ฑ ์‹œ๊ฐ API ํ…Œ์ŠคํŠธ status code ์ˆ˜์ •

* [revert] ์ฝ”๋“œ ์ˆ˜์ • ๋‚ด์—ญ ๋˜๋Œ๋ฆผ

* [feat] ์ง€์›์„œ ๋ชฉ๋ก ๋ณด๊ธฐ API required false์ธ parameter๋“ค์— ๋Œ€ํ•ด default value ์„ค์ •

* [test] ์ง€์›์„œ ๋ชฉ๋ก ๋ณด๊ธฐ API required false์ธ parameter๋“ค์— ๋Œ€ํ•œ ํ…Œ์ŠคํŠธ ์ฝ”๋“œ ์ž‘์„ฑ

* [feat] ์ง€์›์„œ ๋ชฉ๋ก ๋ณด๊ธฐ API enum ํƒ€์ž…์ธ parameter๋“ค์— ๋Œ€ํ•ด allowable values ์„ค์ •

* [test] ์ง€์›์„œ ๋ชฉ๋ก ๋ณด๊ธฐ API enum ํƒ€์ž…์ธ parameter๋“ค์— ๋Œ€ํ•ด ํ…Œ์ŠคํŠธ ์ฝ”๋“œ ์ž‘์„ฑ

* [fix] ์ง€์›์„œ ์—‘์…€ ํŒŒ์ผ ์ƒ์„ฑ ์‹œ๊ฐ API ํ…Œ์ŠคํŠธ status code ์ˆ˜์ •

* [feat] ๋ฉด์ ‘ ์ฐธ์—ฌ ์—ฌ๋ถ€ ํ™•์ธ์šฉ DTO ์ƒ์„ฑ #180

* [feat] ์ตœ์ข… ํ™œ๋™ ์—ฌ๋ถ€ ํ™•์ธ์šฉ DTO ์ƒ์„ฑ #180

* [feat] ๋ถˆ๊ฐ€๋Šฅ ์‚ฌ์œ  unableReason ํ•„๋“œ ๋ฐ ํ•ด๋‹น ํ•„๋“œ ์—…๋ฐ์ดํŠธ ๋กœ์ง ์ถ”๊ฐ€ #180

* [feat] ์ตœ์ข… ํ™œ๋™ ์—ฌ๋ถ€ ํ™•์ธ์šฉ DTO ์ƒ์„ฑ #180

* [feat] ๋ฉด์ ‘ ์ฐธ์—ฌ ๊ฐ€๋Šฅ ์—ฌ๋ถ€ ํ™•์ธ๊ณผ ํ™œ๋™ ๊ฐ€๋Šฅ ์—ฌ๋ถ€ ํ™•์ธ Service ๋กœ์ง ์ž‘์„ฑ #180

* [feat] ํ™œ๋™ ๊ฐ€๋Šฅ ์—ฌ๋ถ€ ํ™•์ธ ์‹œ ์ตœ์ข… ํ•ฉ๊ฒฉ ์—ฌ๋ถ€ ๊ฒ€์ฆํ•˜๋Š” validator ์ž‘์„ฑ #180

* feat: ๋ฉด์ ‘ ์ฐธ์—ฌ ๋ฐ ํ™œ๋™ ๊ฐ€๋Šฅ ์—ฌ๋ถ€ ํ™•์ธ์šฉ Controller ์ž‘์„ฑ

* feat: ๋ฉด์ ‘ ์ฐธ์—ฌ ๋ฐ ํ™œ๋™ ๊ฐ€๋Šฅ ์—ฌ๋ถ€ ํ™•์ธ์šฉ Controller ์ž‘์„ฑ #180

* [refact] ํšŒ๊ณ ๋ก ๋ชฉ๋ก ๋ณด๊ธฐ response dto ํ•„๋“œ ์ˆ˜์ •

* [refact] ํšŒ๊ณ ๋ก ์ƒ์„ธ ๋ณด๊ธฐ/์ˆ˜์ • response dto ํ•„๋“œ ์ˆ˜์ •

* [refact] ๋ฆฌํ”„๋ ˆ์‹œ ํ† ํฐ ๋ฐœ๊ธ‰ ๋กœ์ง ์ˆ˜์ • (#186)

* [refact] ๋ฆฌํ”„๋ ˆ์‹œํ† ํฐ ๋ฐœ๊ธ‰ ๋กœ์ง ์ˆ˜์ • #185

* [refact] ์ƒ์ˆ˜ ์ถ”๊ฐ€

---------

Co-authored-by: yoonsseo <[email protected]>
Co-authored-by: letskuku <[email protected]>
Co-authored-by: Yujeong Lee <[email protected]>
Co-authored-by: ์ด์œค์„œ <[email protected]>
Co-authored-by: suhhyun <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant