From 16cbd3538e7126c622f70e021244ff7247c06e28 Mon Sep 17 00:00:00 2001
From: Alis Akers <alismxwll@gmail.com>
Date: Tue, 15 Oct 2024 15:15:33 -0700
Subject: [PATCH] update deployment to be more configurable via secrets and
 variables

---
 .github/workflows/deployment.yaml    | 11 ++++-------
 terraform/implementation/ecs/main.tf |  2 +-
 2 files changed, 5 insertions(+), 8 deletions(-)

diff --git a/.github/workflows/deployment.yaml b/.github/workflows/deployment.yaml
index f9fe4e4..7d1cce7 100644
--- a/.github/workflows/deployment.yaml
+++ b/.github/workflows/deployment.yaml
@@ -20,10 +20,7 @@ permissions:
   contents: read
 
 env:
-  aws_region: us-east-1
   environment: ${{ github.event.inputs.environment }}
-  owner: "skylight"
-  project: "dibbs"
 
 jobs:
   terraform:
@@ -45,16 +42,16 @@ jobs:
         with:
           role-to-assume: ${{ secrets.AWS_ROLE_ARN }}
           role-session-name: githubDeploymentWorkflow
-          aws-region: ${{ env.aws_region }}
+          aws-region: ${{ secrets.AWS_REGION }}
 
       - name: Terraform
         env:
           ENVIRONMENT: ${{ env.environment }}
           BUCKET: ${{ secrets.TFSTATE_BUCKET }}
           DYNAMODB_TABLE: ${{ secrets.TFSTATE_DYNAMODB_TABLE }}
-          REGION: ${{ env.aws_region }}
-          OWNER: ${{ env.owner }}
-          PROJECT: ${{ env.project }}
+          REGION: ${{ secrets.AWS_REGION }}
+          OWNER: ${{ vars.OWNER }}
+          PROJECT: ${{ vars.PROJECT }}
         shell: bash
         run: |
           echo "ENVIRONMENT=$ENVIRONMENT" >> .env
diff --git a/terraform/implementation/ecs/main.tf b/terraform/implementation/ecs/main.tf
index e396440..9c2fd7e 100644
--- a/terraform/implementation/ecs/main.tf
+++ b/terraform/implementation/ecs/main.tf
@@ -35,5 +35,5 @@ module "ecs" {
   # internal       = false
 
   # If the intent is to disable authentication, set ecr_viewer_app_env to "test" (default is "prod")
-  ecr_viewer_app_env = "test"
+  # ecr_viewer_app_env = "test"
 }