Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meta properties in header need fixing #94

Open
glpoulter opened this issue Aug 25, 2022 · 1 comment
Open

Meta properties in header need fixing #94

glpoulter opened this issue Aug 25, 2022 · 1 comment

Comments

@glpoulter
Copy link
Member

glpoulter commented Aug 25, 2022

A rendering issue was discovered when a url was input into the description field of either a project or a test case.

It turns out the meta property "description" which is in the header part of each template actually was taking the content of the description field but as it was referenced with double quotes, when a url was input into the description the first of the double quotes in the url closed the opening ones for the declaration of the meta property. Thus the rest of the description appeared in the head of the html!

Changing these double quotes to singles, as in commit 57dc256 appeared to fix the problem however presumably the intended meta data description is not what a user inputs into the description field so work still to be done

glpoulter added a commit that referenced this issue Aug 25, 2022
@glpoulter
Copy link
Member Author

Single quotes as per 57dc256 seemed like a good idea but if there is a single quote in the description then the same thing happens.

For the time being have removed the meta property description (see commit referenced above) but need to workout what this actually should be and put that in instead!

glpoulter added a commit that referenced this issue Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant