Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement decompose_sketch #6

Open
TobiasJacob opened this issue May 26, 2024 · 2 comments
Open

Implement decompose_sketch #6

TobiasJacob opened this issue May 26, 2024 · 2 comments
Labels
next-up

Comments

@TobiasJacob
Copy link
Collaborator

Implement decompose_sketch at src/decompose/mod.rs:9.
@MattFerraro
Copy link

hey Tobias,

Don't let me stop you from doing what you wanna do, but I'm curious: what value do we get out of identifying Faces in ISOtope? It's a nasty problem with a zillion edge cases that we already do a decent (but not perfect) job of in CADmium: https://github.com/CADmium-Co/CADmium/blob/238d3e23994a9824d5db35c464428e51ceb12b20/packages/cadmium/src/sketch/intersections.rs#L498

@TobiasJacob
Copy link
Collaborator Author

I think we should copy over the code from CADmium, but we can also leave it there. However you like it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
next-up
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MattFerraro @TobiasJacob