Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove the /CADmium suffix from the URL #112

Open
MattFerraro opened this issue Jun 23, 2024 · 4 comments
Open

remove the /CADmium suffix from the URL #112

MattFerraro opened this issue Jun 23, 2024 · 4 comments
Labels
3D UI good first issue Good for newcomers

Comments

@MattFerraro
Copy link
Collaborator

currently when you run locally using pnpm dev, you can access the editor at http://127.0.0.1:5173/ which seems correct.

but the deployed page at https://cadmium-co.github.io/CADmium/ contains a trailing /CADmium/. Let's remove that!

@MattFerraro MattFerraro added good first issue Good for newcomers 3D UI labels Jun 23, 2024
@sebsebmc
Copy link
Contributor

sebsebmc commented Jun 25, 2024

I believe this is a requirement of Github Pages. The formatting is always <owner-name>.github.io/<repo-name>

If we want to use just https://cadmium-co.github.io that would be an "organization"/"user" site, which requires using a repository named <organization>.github.io that is used to publish the site.

See https://docs.github.com/en/pages/getting-started-with-github-pages/about-github-pages#types-of-github-pages-sites

@MattFerraro
Copy link
Collaborator Author

Thanks for the research! I'm not sure there's a good solution here because I don't want to move the repo. It might be best to just bite the bullet and pay for hosting somewhere other than gh-pages.

@dzervas
Copy link
Collaborator

dzervas commented Jun 28, 2024

if we move to custom domain (also free if I'm not mistaken) this is a non-issue - and I think the best case is to use an app subdomain to have the apex domain for docs/homepage/etc.

@Its-Just-Nans
Copy link

Its-Just-Nans commented Jun 30, 2024

Hi

I think you can just use a method like that

https://www.nieknijland.nl/blog/how-to-trigger-a-github-action-workflow-in-another-repository

  1. Create the repository cadmium-co.github.io
  2. Move most of .github/workflows/ci.yml to the new repo
  3. Change .github/workflows/ci.yml to create a dispatch event
  4. Modify the yml accordingly to trigger on this event

The final url would be https://cadmium-co.github.io/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3D UI good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants