Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MangaSee search returns too many results - Fuzzysearch #132

Closed
ghost opened this issue Feb 27, 2024 · 27 comments
Closed

MangaSee search returns too many results - Fuzzysearch #132

ghost opened this issue Feb 27, 2024 · 27 comments
Assignees
Labels
bug Something isn't working

Comments

@ghost
Copy link

ghost commented Feb 27, 2024

What is broken?

It just doesnt find anything in time, like im just staring at that screen for 3-5 minutes.

image-2

FYI: MangaSee offers higher quality scans and also allows very high download speeds without throttling, thats why im using it.

FMD2 and Kaizuko both find search results for MangaSee in 1-2 seconds for One Piece that Tranga struggled with for minutes....

Idk why, but youre also getting wayyyy too many results for MangaSee searches...

Like One Piece returns 166 results while Kaizuko and FMD2 both only give about 4-5 results.

Log-output

[02/27/2024 12:11:03.204] ChromiumDownl | Starting Browser.
[02/27/2024 12:11:04.164] ChromiumDownl | Starting Browser.
[02/27/2024 12:11:04.407]       JobBoss | Next job in
[02/27/2024 12:11:04.504]        Server | Listening on http://*:6531/
[02/27/2024 12:15:49.9  ]      Mangasee | Searching Publications. Term="One Piece"
[02/27/2024 12:15:52.632] ChromiumDownl | Page loaded.
[02/27/2024 12:15:52.864]      Mangasee | Total available manga: 7950 Filtered down to: 166
[02/27/2024 12:15:55.248] ChromiumDownl | Page loaded.
[02/27/2024 12:15:57.345] ChromiumDownl | Page loaded.
[02/27/2024 12:15:57.351]      Mangasee | Saving cover to /usr/share/tranga-api/imageCache/638446329552963622.jpg
[02/27/2024 12:15:59.376] ChromiumDownl | Page loaded.
[02/27/2024 12:16:01.456] ChromiumDownl | Page loaded.
[02/27/2024 12:16:01.500]      Mangasee | Saving cover to /usr/share/tranga-api/imageCache/638446329593889540.jpg

Repeat for 100 times...

[02/27/2024 12:26:50.547] ChromiumDownl | Page loaded.
[02/27/2024 12:26:52.595] ChromiumDownl | Page loaded.
[02/27/2024 12:26:52.599]      Mangasee | Saving cover to /usr/share/tranga-api/imageCache/638446336105760082.jpg
[02/27/2024 12:26:52.608]      Mangasee | Retrieved 166 publications. Term="One Piece"

Additional stuff

No response

@ghost ghost added the bug Something isn't working label Feb 27, 2024
@C9Glax
Copy link
Owner

C9Glax commented Feb 27, 2024

#75

Read up on this. The Mangasee search itself is iffy, so I implemented my own, which sadly right now returns a lot of fake results. This is turn makes the search take ages, because tranga downloads all covers.

Will repurpose this issue to improve the search for Mangasee.

@C9Glax C9Glax changed the title [It broke]: Searching Manga on MangaSee takes too long MangaSee search returns too many results Feb 27, 2024
@C9Glax C9Glax self-assigned this Feb 27, 2024
@ghost
Copy link
Author

ghost commented Feb 27, 2024

#75

Read up on this. The Mangasee search itself is iffy, so I implemented my own, which sadly right now returns a lot of fake results. This is turn makes the search take ages, because tranga downloads all covers.

Will repurpose this issue to improve the search for Mangasee.

Sorry but this is plain wrong, mangasee is one of the easier sources to scrape...

Litterally just use https://mangasee123.com/search/?sort=s&desc=false&name=

and then follow by the name entered in the text field replacing space with %20

Example for Made in Abyss:
image

The Results:
image

@ghost
Copy link
Author

ghost commented Feb 27, 2024

I just noticed youre using C#, i will clone the repo and have a look myself if i can fix it.

@C9Glax
Copy link
Owner

C9Glax commented Feb 27, 2024

Sorry but this is plain wrong

image

right.

@C9Glax
Copy link
Owner

C9Glax commented Feb 27, 2024

I am not stupid. Why would I go through the effort of writing my own stupid filter if I could use the site, like with every other connector.

@ghost
Copy link
Author

ghost commented Feb 27, 2024

I just noticed youre using C#, i will clone the repo and have a look myself if i can fix it.

Thats not a problem for you to fix tho, thats a general issue with MangaSee.
People using MangaSee know how to move around these hurldles by using Romanji or using just a few words of the title.

@ghost
Copy link
Author

ghost commented Feb 27, 2024

I am not stupid. Why would I go through the effort of writing my own stupid filter if I could use the site, like with every other connector.

Not saying youre stupid, but why write your own if you can just use the default way of doing it which runs 10000 times faster ?

@ghost
Copy link
Author

ghost commented Feb 27, 2024

Like i see 0 benefit if your search returns 166 Results for OP and takes 5 minutes while using the default search would take 5 seconds and give back 3 Results

@C9Glax
Copy link
Owner

C9Glax commented Feb 27, 2024

Because the default way of doing it doesn't work!
Saying "it is plain wrong", when the search is indeed fucking broken, and you have to

move around these hurldles by using Romanji or using just a few words of the title

is not correct.

@ghost
Copy link
Author

ghost commented Feb 27, 2024

Because the default way of doing it doesn't work! Saying "it is plain wrong", when the search is indeed fucking broken, and you have to

move around these hurldles by using Romanji or using just a few words of the title

is not correct.

It does work and thats how i and others have been using it in FMD2 for years.

@ghost
Copy link
Author

ghost commented Feb 27, 2024

Its better to move around the Scrapers Search hurdles, especially if your own implementation is actually working even less.

@ghost
Copy link
Author

ghost commented Feb 27, 2024

Again im not trying to be mean here, but thats how it is at the moment.

@ghost
Copy link
Author

ghost commented Feb 27, 2024

If youre not willing to fix this for some reason, then im just going to do it myself and make a fork with it fixed

@C9Glax
Copy link
Owner

C9Glax commented Feb 27, 2024

Yes it works. But not correctly. My search works, in that it returns ALL feasible (meaning all matches) for a string. Returning nothing because you are missing an apostrophe is in my book "not working".

Yes it returns too many results, and the best way around that would be a fuzzy search, to which I just not have gotten.
The best way right now to add Mangasee manga is to use a direct link to the manga.

@ghost
Copy link
Author

ghost commented Feb 27, 2024

Because the default way of doing it doesn't work! Saying "it is plain wrong", when the search is indeed fucking broken, and you have to

move around these hurldles by using Romanji or using just a few words of the title

is not correct.

Yes it works. But not correctly. My search works, in that it returns ALL feasible (meaning all matches) for a string. Returning nothing because you are missing an apostrophe is in my book "not working".

Yes it returns too many results, and the best way around that would be a fuzzy search, to which I just not have gotten. The best way right now to add Mangasee manga is to use a direct link to the manga.

Sorry but isnt it also lowkey out of scope to fix MangaSees broken search, that should be the job of the admins of mangasee.
But the users dont really care cuz its working "well enough", including me.
Why not revert it to the original Search and put this on a testing branch till it works like you want it to ?

@ghost
Copy link
Author

ghost commented Feb 27, 2024

If youre not willing to fix this for some reason, then im just going to do it myself and make a fork with it fixed

Again just tell me and i will create a fork called TrangaSee for the time beeing, till you fixed the search.

@C9Glax
Copy link
Owner

C9Glax commented Feb 27, 2024

Because people have been complaining that certain Manga just don't come up in results.
Of course it is up to Mangasee admins to fix their search, and if you want to use their search function you can do that!
You can add Manga to Tranga by using the URL of the Manga.

You are free to create your own fork, there is a commit somewhere that had the original search, you can just revert that and it should do the job.

@ghost
Copy link
Author

ghost commented Feb 27, 2024

You can add Manga to Tranga by using the URL of the Manga.

Dont quite get how ? just paste the url in the searchbar ?

@ghost
Copy link
Author

ghost commented Feb 27, 2024

or only with the api directly ?

@ghost
Copy link
Author

ghost commented Feb 27, 2024

Also if i came over negative or mean, thats not what i wanted.
Im not really good with communicating and such stuff :(

@C9Glax
Copy link
Owner

C9Glax commented Feb 27, 2024

Like this
image
So with the connector selected

@ghost
Copy link
Author

ghost commented Feb 27, 2024

Thank you so much, then i will use this :D

@ghost ghost closed this as completed Feb 27, 2024
@ghost ghost reopened this Feb 27, 2024
@ghost
Copy link
Author

ghost commented Feb 27, 2024

Oops you wanted to keep this open to track this.

@C9Glax
Copy link
Owner

C9Glax commented Feb 27, 2024

Yup, thanks 👍🏼

@db-2001
Copy link
Collaborator

db-2001 commented Feb 28, 2024

Sorry but this is plain wrong

image

right.

Noticing URL has "+" instead of "%20" for spaces, not sure if this makes a difference, just brining it up.

@C9Glax
Copy link
Owner

C9Glax commented Feb 28, 2024

Nope, doesn't change a thing.

@C9Glax C9Glax changed the title MangaSee search returns too many results MangaSee search returns too many results - Fuzzysearch Apr 1, 2024
@C9Glax C9Glax mentioned this issue Apr 25, 2024
@C9Glax C9Glax linked a pull request Apr 26, 2024 that will close this issue
@C9Glax
Copy link
Owner

C9Glax commented Jun 29, 2024

This should be fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants