Remove validation of src for AvailableData

I decided to remove the check since we will need to move it to to the
aiida part after PR #136 is merged. With #136 we need to consider remote
data which we cannot check neigher in core nor parsing. So moving this
now to the yaml parsing would require the adoption of many test which
will be anyway not be needed.

Author: agoscinski

src/sirocco/core/graph_items.py

@@ -62,7 +62,7 @@ class AvailableData(Data):
 
     @classmethod
     def from_config(cls, config: ConfigBaseData, config_rootdir: Path, coordinates: dict) -> Self:
-        src = cls._validate_src(config.name, config.src, config_rootdir)
+        src = cls._validate_src(config.src, config_rootdir)
         return cls(
             name=config.name,
             computer=config.computer,
@@ -72,21 +72,14 @@ def from_config(cls, config: ConfigBaseData, config_rootdir: Path, coordinates:
         )
 
     @staticmethod
-    def _validate_src(name: str, config_src: Path | None, config_rootdir: Path | None = None) -> Path | None:
+    def _validate_src(config_src: Path | None, config_rootdir: Path | None = None) -> Path | None:
         if config_src is None:
             return None
         if config_rootdir is None and not config_src.is_absolute():
             msg = f"Cannot specify relative path {config_src} for namelist while the rootdir is None"
             raise ValueError(msg)
 
-        src = config_src if config_rootdir is None else (config_rootdir / config_src)
-        if not src.exists():
-            msg = f"Data {name} in path {src} does not exist."
-            raise FileNotFoundError(msg)
-        if not src.is_file():
-            msg = f"Data {name} in path {src} is not a file."
-            raise OSError(msg)
-        return src
+        return config_src if config_rootdir is None else (config_rootdir / config_src)
 
 
 class GeneratedData(Data):

tests/conftest.py

@@ -58,34 +58,24 @@ def icon_filepath_executable() -> str:
 
 
 @pytest.fixture(scope="session")
-def available_datas(tmp_path_factory):
-    tmp_path = tmp_path_factory.mktemp("data")
-    available_datas = [
-        models.ConfigAvailableData(name="available", type=models.DataType.FILE, src=(tmp_path / "foo.txt"))
-    ]
-    # validation in core representation requires that available data exists
-    for available_data in available_datas:
-        available_data.src.touch()
-    return available_datas
-
-
-@pytest.fixture(scope="session")
-def minimal_config(available_datas) -> models.ConfigWorkflow:
+def minimal_config() -> models.ConfigWorkflow:
     return models.ConfigWorkflow(
         name="minimal",
         rootdir=pathlib.Path("minimal"),
         cycles=[models.ConfigCycle(name="minimal", tasks=[models.ConfigCycleTask(name="some_task")])],
         tasks=[models.ConfigShellTask(name="some_task", command="some_command")],
         data=models.ConfigData(
-            available=available_datas,
+            available=[
+                models.ConfigAvailableData(name="available", type=models.DataType.FILE, src=pathlib.Path("foo.txt"))
+            ],
             generated=[models.ConfigGeneratedData(name="bar", type=models.DataType.DIR, src=pathlib.Path("bar"))],
         ),
         parameters={},
     )
 
 
 @pytest.fixture(scope="session")
-def minimal_invert_task_io_config(available_datas) -> models.ConfigWorkflow:
+def minimal_invert_task_io_config() -> models.ConfigWorkflow:
     return models.ConfigWorkflow(
         name="minimal",
         rootdir=pathlib.Path("minimal"),
@@ -111,7 +101,9 @@ def minimal_invert_task_io_config(available_datas) -> models.ConfigWorkflow:
             models.ConfigShellTask(name="task_b", command="command_b"),
         ],
         data=models.ConfigData(
-            available=available_datas,
+            available=[
+                models.ConfigAvailableData(name="available", type=models.DataType.FILE, src=pathlib.Path("foo.txt"))
+            ],
             generated=[
                 models.ConfigGeneratedData(name="output_a", type=models.DataType.DIR, src=pathlib.Path("bar")),
                 models.ConfigGeneratedData(name="output_b", type=models.DataType.DIR, src=pathlib.Path("bar")),