Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve description for event, stattrak, ... #93

Open
piyanggoon opened this issue Feb 3, 2024 · 5 comments
Open

Improve description for event, stattrak, ... #93

piyanggoon opened this issue Feb 3, 2024 · 5 comments
Labels
enhancement New feature or request

Comments

@piyanggoon
Copy link
Contributor

AK-47 | Redline

Powerful and reliable, the AK-47 is one of the most popular assault rifles in the world. It is most deadly in short, controlled bursts of fire.

to

Powerful and reliable, the AK-47 is one of the most popular assault rifles in the world. It is most deadly in short, controlled bursts of fire. It has been painted using a carbon fiber hydrographic and a dry-transfer decal of a red pinstripe. Never be afraid to push it to the limit

@ByMykel ByMykel added the enhancement New feature or request label Feb 3, 2024
@piyanggoon
Copy link
Contributor Author

Sticker | FURIA | Katowice 2019

50% of the proceeds from the sale of this sticker support the included players and organizations.

to

This item commemorates the 2019 IEM Katowice CS:GO Championship.

This sticker can be applied to any weapon you own and can be scraped to look more worn. You can scrape the same sticker multiple times, making it a bit more worn each time, until it is removed from the weapon.

50% of the proceeds from the sale of this sticker support the included players and organizations.

@piyanggoon piyanggoon changed the title Add more description for pattern. Add more description for pattern, missing word. Feb 3, 2024
@piyanggoon
Copy link
Contributor Author

piyanggoon commented Feb 4, 2024

Now pull request for pattern, but still missing on "CSGO_Event_"

  "CSGO_Event_Desc"							"This item commemorates the %s1."
  "CSGO_Event_Details_Desc"					"It was dropped during the %s1 match between %s2 and %s3."
  "CSGO_Event_Details_MvpDesc"				"It was dropped during the %s1 match between %s2 and %s3, and autographed by %s4 who was the most valuable player in that round."
  "CSGO_Event_Details_MvpDesc_UnknownPlayer"	"It was dropped during the %s1 match between %s2 and %s3, and autographed by the professional player who was the most valuable player in that round."

Example.

This item commemorates the 2016 ESL One Cologne CS:GO Championship.

It was dropped during the Group Stage match between Flipsid3 Tactics and Ninjas in Pyjamas, and autographed by Yegor Markelov who was the most valuable player in that round.

@ByMykel
Copy link
Owner

ByMykel commented Feb 5, 2024

Does your PR #96 fixes this issue?

@piyanggoon
Copy link
Contributor Author

piyanggoon commented Feb 5, 2024

#96 not include "CSGO_Event_".

Here example item

CSGO_Event_Desc, CSGO_Event_Details_Desc
Souvenir XM1014 | Blue Steel (Field-Tested)

CSGO_Event_Desc, CSGO_Event_Details_MvpDesc
Souvenir Nova | Predator (Well-Worn)

And still missing desc on StatTrak, StatTrak™, ... try checking on steam market.

@ByMykel
Copy link
Owner

ByMykel commented Feb 5, 2024

#96 not include "CSGO_Event_".

Here example item

CSGO_Event_Desc, CSGO_Event_Details_Desc
Souvenir XM1014 | Blue Steel (Field-Tested)

CSGO_Event_Desc, CSGO_Event_Details_MvpDesc
Souvenir Nova | Predator (Well-Worn)

And still missing desc on StatTrak, StatTrak™, ... try checking on steam market.

oh i see it. But this would be better used in skins_not_grouped.json. Because we can differentiate between normal, sourvenir and stattrak.

I don't have much free time, so feels free to open a PR adding this if you desire it

@piyanggoon piyanggoon changed the title Add more description for pattern, missing word. Improve description for event, stattrak, ... Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants