Redirect Users to Homepage After Successful Signup (#39) #46
+2,582
−72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR @Varundeep111. We would get to review your PR soon. |
|
@ItsAbhinavM Please review it |
ItsAbhinavM
reviewed
Dec 16, 2024
| } else { | ||
| // If login fails after signup | ||
| isLoading.value = false; | ||
| _showErrorDialog('Signup successful, but automatic login failed'); |
There was a problem hiding this comment.
Can you change the "automatic login" part to something else, feels a bit weird. You don't have to tell the user that an error occurred. Would be fine if you just put
"Signup successful".
There was a problem hiding this comment.
I don't think this file is necessary, could you delete it.
|
@Varundeep111 Could u make the suggested changes and then we would be good to merge it in ? |
|
@angrezichatterbox, after @Varundeep111 finishes the update, I think we are good to merge the PR. Thank you @Varundeep111 for your contribution; I hope we can see more contributions from you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request enhances the signup flow by redirecting users directly to the homepage upon successful account creation. This improvement eliminates the need for users to manually navigate to the sign-in page and re-enter credentials, resulting in a smoother and more user-friendly experience.
Key Changes:
Automatic Login Post-Signup:
Upon successful signup, the system automatically authenticates the user and navigates them to the homepage.
Loading Feedback:
A loading indicator is displayed during the signup and login process, providing visual feedback to users.
Error Handling:
Added robust error-handling mechanisms to manage potential issues during the automatic login process.
Fallback navigation or messaging is implemented in case of login failure.
Code Updates:
Updated navigation logic to streamline the transition from signup to the homepage.
Adjusted API integration to handle signup and automatic login in a single flow.
Branch Information:
Branch Name: feature/39-signup-navigation-homepage
Implements feature #39 as described in the issue.
Related Issues:
Closes #39
Additional Notes:
Feedback on the automatic login implementation and error-handling logic is welcome.
Suggestions for further optimization of the signup flow are appreciated.