Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement new auth system #14

Closed
hrideshmg opened this issue Nov 22, 2024 · 1 comment · Fixed by #16
Closed

Implement new auth system #14

hrideshmg opened this issue Nov 22, 2024 · 1 comment · Fixed by #16
Assignees
Labels
enhancement New feature or request

Comments

@hrideshmg
Copy link
Member

hrideshmg commented Nov 22, 2024

Currently the backend uses the django rest framework's TokenAuthentication system for serving and managing user tokens. There are several drawbacks to this systems including but not limited to -

  1. Tokens being limited to one per user which means that users cannot sign into the website and mobile app at the same time.
  2. Tokens are stored without encryption in the database
  3. Tokens don't have any expiry time

There are a few potential systems that we could use instead:
https://github.com/jazzband/django-rest-knox
https://github.com/jazzband/django-oauth-toolkit?tab=readme-ov-file
https://github.com/pennersr/django-allauth

@hrideshmg hrideshmg added the enhancement New feature or request label Nov 22, 2024
@hrideshmg hrideshmg self-assigned this Nov 22, 2024
@hrideshmg
Copy link
Member Author

Decided to use django-rest-knox since allauth requires additional configuration for compatibility with DRF

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant