Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add validation to confirm missile spawned #414

Closed
DarkGuardsman opened this issue May 30, 2023 · 0 comments
Closed

Add validation to confirm missile spawned #414

DarkGuardsman opened this issue May 30, 2023 · 0 comments
Labels
defect Something not originally thought of but is negatively impacting gameplay

Comments

@DarkGuardsman
Copy link
Member

https://github.com/BuiltBrokenModding/ICBM-Classic/blob/0f207d6b88417f33627d51e023381fb93ab358f2/src/main/java/icbm/classic/content/missile/tracker/MissileTrackerWorld.java#LL221C32-L221C32

Above code is not checking if the world spawned the missile from the simulation system. In the event it returns false we need to retry or at minimal log an error for users.
@DarkGuardsman DarkGuardsman added the defect Something not originally thought of but is negatively impacting gameplay label Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
defect Something not originally thought of but is negatively impacting gameplay
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DarkGuardsman