Replies: 13 comments 18 replies
-
|
INITIAL ISSUE DESCRIPTION: I'm also looking into a similar issue as @macumber. Trying to get TBD released in BCL as v2.4.1. I get a 404 error for the "action" : "released" webhook/payload (Dan's successful - I'm not) with the following (similar) error message:
This could be a completely separate issue, but the feedback is the same. EDIT : Just deleted v2.4.1, moved on to v2.4.2. Only change on the repo side (i.e. v2.4.1 vs v2.4.2) was adding the .md extension to the root LICENSE. As with @macumber, GitHub now reports success ("200"), yet getting the same feedback from BCL.
Tried again with v2.4.3, same result.
|
Beta Was this translation helpful? Give feedback.
-
|
@macumber and @rd2 Hi! This was an error on the BCL side (expired token). Sorry for the hassle. I've updated and manually added your releases to the BCL. Everything should be good now, but let me know if you run into any more issues. thanks! -Katherine |
Beta Was this translation helpful? Give feedback.
-
|
Thanks @kflemin, glad it's working! If I download from BCL however, I get v2.4.1 (and not the most recent v2.4.3). This may be due to my repeated attempts with successive patched versions. If there's no easy fix on your side, should I simply re release? Or move on to v2.4.4.?
|
Beta Was this translation helpful? Give feedback.
-
|
@rd2, I just downloaded from the page in your screenshot... the version modified in the measure.xml file that I downloaded has date 2022-06-12...is that not the latest version? Also, I can see v2.4.3 from this search: https://bcl.nrel.gov/api/search/thermal%20bridging Let me know if it still looks wrong for you... |
Beta Was this translation helpful? Give feedback.
-
|
Thanks for the follow-up @kflemin. My efforts in trying to get BCL to accept the latest release included re-releasing v2.4.1, then releasing v2.4.2, then 2.4.3 (each with slight changes). Some of these attempts occurred on 2022-06-12, the latest (v2.4.3) on 2022-06-13 (success, see figure).
Yet if one downloads TBD from BCL, it's v2.4.1 (one can CTRL-F "v2.4" in the ua.md file under resources). The latest release is v2.4.3. Any webhook payload on your side with "v2.4.1" or "v2.4.2" can be discarded, as I have deleted them from TBD's releases. Depending on what you dig up, I can always release v2.4.4 if needed. |
Beta Was this translation helpful? Give feedback.
-
|
@rd2, I removed and re-added the v2.4.3 release with the same results...The 'webhook' and my manual process pulls the source code . zip from this page: https://github.com/rd2/tbd/releases/tag/v2.4.3. That one has version 2.4.1 in the ua.rb file...which is what i'm seeing on BCL as well. Perhaps something went wonky in the release? If you want to try making a new one go for it, it should work this time. |
Beta Was this translation helpful? Give feedback.
-
|
Once again, thanks for your efforts @kflemin. Took me a while to figure out what was happening. In the above figure (about an hour ago), there's a 48-hour lag between the .zip/.tar.gz files I locally created/dragged/dropped vs what GitHub generates from the current source code (last committed/pushed 2 days ago) at the time of the release. A GitHub user wouldn't necessarily notice this gap if they dragged/dropped + released all under a minute. So I guess BCL instructions are pulling the .zip content that GitHub prepares behind the scenes at release (not the .zip file I prepared). So I just committed/pushed a recent change to master (a minor, yet relevant update). GitHub's .zip file and the one I dragged/dropped should now be the same.
The issue I seem to have now is syncing with BCL.
I suspect BCL doesn't allow overwriting an existing "v2.4.3" tag? If so, I think BCL measure publishers should be allowed to edit releases through GitHub webhooks (GitHub allows editing a release). Could I therefore ask you again to manually reset BCL's v2.4.3 TBD release? The alternative, it seems, would be to release a v2.4.4 (which I would like to avoid, if I can). Merci !
|
Beta Was this translation helpful? Give feedback.
-
|
@rd2 Okay, I just deleted v2.4.3 from BCL (you are right that it will not overwrite an existing tag on BCL). Fingers crossed that it works this time! :) |
Beta Was this translation helpful? Give feedback.
-
|
Works !! Thanks a bunch @kflemin !! |
Beta Was this translation helpful? Give feedback.
-
|
As this is a discussion (not an issue), how does NREL feel with maybe revising which types of webhook requests from GitHub should be admissible?
|
Beta Was this translation helpful? Give feedback.
-
|
These are good questions! At the least, it might be good for BCL to allow re-releases...the BCL should probably match what users would see on the individual GitHub repos, and if that's allowed on github we should probably handle it on BCL as well. I'll keep it in mind! |
Beta Was this translation helpful? Give feedback.
-
|
@kflemin , @macumber (Dan's co-author, so I'm dragging him into this) : I again have a similar issue with TBD v3.0.3 (last night). The recent deliveries look like this:
I think we can ignore the failed re-release (I believe re-releases always fail ?!). But the final ("200" : success) message looked promising:
Alas, TBD v3.0.2 remains the latest available version on BCL. TBD v3+ were all (successfully) released/published in the same manner (same settings). Yesterday's released is the only hiccup. Anything on BCL's side? Thanks. |
Beta Was this translation helpful? Give feedback.
-
|
hi @brgix! hi @macumber! just for reference, the BCL uses the "published" delivery to add a new release, so if that one fails it won't get indexed into the bcl. but again, the error was on my end. |
Beta Was this translation helpful? Give feedback.
-
|
@kflemin fantastic! Merci! |
Beta Was this translation helpful? Give feedback.
-
|
Thanks Kat! |
Beta Was this translation helpful? Give feedback.
-
|
@kflemin , @macumber : Just released v3.1, and am getting similar issues: |
Beta Was this translation helpful? Give feedback.
-
|
@brgix, this was again a credentials issue on the BCL side, ugh! BCL didn't have permissions to download the release. I've fixed it manually and uploaded 3.1.0 to the BCL. Hopefully next time it will work! sorry about that! |
Beta Was this translation helpful? Give feedback.
-
|
Thanks @kflemin ! |
Beta Was this translation helpful? Give feedback.
-
|
@kflemin , @macumber : Just released v3.1.1 yesterday: |
Beta Was this translation helpful? Give feedback.
-
|
I did another manual update, it should be on BCL now! |
Beta Was this translation helpful? Give feedback.
-
|
Merci! |
Beta Was this translation helpful? Give feedback.
-
|
Hey @kflemin : Yup, that time of the year. Just released TBD v3.3.0, and got another 400 error on
Can you take a look on your side? Thanks. |
Beta Was this translation helpful? Give feedback.
-
|
Ack, sorry! Fixed and released on BCL now: https://bcl.nrel.gov/repos/6721d9ea-0704-11ec-810a-4aec1d5be697 |
Beta Was this translation helpful? Give feedback.
-
|
Merci @kflemin ! |
Beta Was this translation helpful? Give feedback.
-
|
Bonjour @kflemin, @macumber. Maybe related to recent BCL difficulties, but the latest TBD v3.4.1 has a 404 failed delivery error. It's certainly not popping up under BCL. Let me know if you need details. Merci! |
Beta Was this translation helpful? Give feedback.
-
|
sorry! the release should be on BCL now! |
Beta Was this translation helpful? Give feedback.
-
|
Merci @kflemin - all good! |
Beta Was this translation helpful? Give feedback.
-
|
Hi @kflemin ... yep, another 404 failed delivery error (v3.4.2). Let me know if I need to do anything more on my end. Thanks. |
Beta Was this translation helpful? Give feedback.
-
|
Hmm, this time I don't know why it didn't work. Usually it's because the token expired but not this time. Would you mind sending me the error message you can see on your end? I did add the release locally so you should be all set! |
Beta Was this translation helpful? Give feedback.
-
|
Here's the "release.created", "release.released" & "release.published" feedback (from what I can tell, exactly the same; not very informative): <title>Request Rejected</title>An error has occurred. Please consult with your administrator.Your support ID is: 1779917883621227788 [Go Back] ... let me know if you want me to share the actual (automated) requests. |
Beta Was this translation helpful? Give feedback.
-
|
this is perfect, thank you. any change there's a timestamp that you can see? |
Beta Was this translation helpful? Give feedback.
-
Hey everyone! I posted a new test release today, https://github.com/automaticmagic/automaticmagic-measures/releases, just to make sure things were still working on the BCL. I saw three webhooks fire off from my repo to the BCL (created, published, and released). The created and published ones were rejected by the BCL but the released one got a 200 success. However, the BCL page for my org https://bcl.nrel.gov/repos/e7d3dccc-04a8-11ec-a8db-129880bd8b7d shows that there was an error fetching https://api.github.com/repos/automaticmagic/automaticmagic-measures/zipball/v0.1.2. That link works in a browser for me. Is there some order dependency between the three webhooks? Does BCL retry if the zipball fetch fails?
I tried to redeliver the released webhook and got this error reply:
<html><head><title>Request Rejected</title></head><body>An error has occurred. Please consult with your administrator.<br><br>Your support ID is: 16321039148529138914<br><br><a href='javascript:history.back();'>[Go Back]</a></body></html>Beta Was this translation helpful? Give feedback.
All reactions