Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example Notebook Problems #190

Open
WilliamIX opened this issue Sep 30, 2020 · 4 comments
Open

Example Notebook Problems #190

WilliamIX opened this issue Sep 30, 2020 · 4 comments
Assignees
Milestone

Comments

@WilliamIX
Copy link
Collaborator

WilliamIX commented Sep 30, 2020

Found some problems with example notebooks. Making a list here:

  1. In Notebook 1 (CRNs) the text doesn't quite match the code for the new way propensities work.
  2. Notebook 4 (Gene Regulation) Example 4 (Regulated Promoter) is not working correctly for some reason. Probably the parameter values?
@WilliamIX WilliamIX added this to the 1.1.0 milestone Sep 30, 2020
@WilliamIX WilliamIX self-assigned this Oct 7, 2020
@zoltuz
Copy link
Member

zoltuz commented Oct 8, 2020

Suggestion for the first notebook:

  • Point out the colon notation for complexes (add reference: BFS chapter 2)
  • Explain that A + C <-> E -> D is the same as A + C <-> E and E -> D (for beginners)

@zoltuz
Copy link
Member

zoltuz commented Oct 13, 2020

typo in the markdown cell "Non-massaction propensities in BioCRNpyler": propritional species -> proportional species
https://github.com/BuildACell/BioCRNPyler/blob/master/examples/1.%20Building%20CRNs%20Directly.ipynb

@WilliamIX WilliamIX modified the milestones: 1.1.0, Low Priority Dec 14, 2020
@WilliamIX
Copy link
Collaborator Author

At the end of this process, read through all the example notebooks and check for consistency, clarity, etc.

@WilliamIX WilliamIX changed the title Example Notebook Problem Example Notebook Problems Dec 14, 2020
@WilliamIX
Copy link
Collaborator Author

Dilution listed as part of TxTlExtract in the Transcription / Translation notebook.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants