Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Control App config using ENV Variables #6

Open
jonesalexr opened this issue Feb 25, 2021 · 2 comments
Open

Control App config using ENV Variables #6

jonesalexr opened this issue Feb 25, 2021 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@jonesalexr
Copy link

jonesalexr commented Feb 25, 2021

Instead (or addition) to having to have a yml file control endpoint, API Key, and optional attributes, let them be passed through docker commandline. The app in existing state already has environment variables, they just dont seem to be used. A good sample project that uses these is below.
https://hub.docker.com/r/scyto/unifibrowser
https://grafana.com/docs/grafana/latest/installation/docker/

So Ideally docker command would look like the below.
docker run --name hubitat2prom -p:5000:5000 -e HE_URI=http://192.168.1.12/apps/api/1006/devices -e HE_ACCESS_TOKEN=123456 -e HE_ATTRIBUTES=battery,humidity,illuminence,level,switch,temperature proffalken/hubitat2prom:latest

screenshot below showing what the current env var for this docker shows.
2021-02-25 10_48_35-Clipboard

@patoarvizu
Copy link

+1

Specially being able to inject the access token via an environment variable. It would make it easier to run this on container orchestration platforms (Kubernetes, Nomad) securely.

@proffalken proffalken added enhancement New feature or request good first issue Good for newcomers labels Mar 1, 2021
@otakup0pe
Copy link

This seems to be currently supported via the HE_URI, HE_ACCESS, and HE_METRICS environment variables...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants