Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abort individual scripts when steps fail #21

Open
evanw555 opened this issue Feb 28, 2020 · 0 comments · May be fixed by #22
Open

Abort individual scripts when steps fail #21

evanw555 opened this issue Feb 28, 2020 · 0 comments · May be fixed by #22

Comments

@evanw555
Copy link

Similar to #13, except for the individual build and deploy scripts. That linked PR adds set -e to the beginning of the root entrypoint.sh script, but we should also do the same for the individual tasks.

My use case uses the root one for building and deploying on push, but uses the build-only script for testing PRs (thus, having this abort setting is crucial to testing PR builds).

It's a simple change, I'll likely just end up opening a PR myself.

@evanw555 evanw555 linked a pull request Feb 28, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant