Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silent failure during Install step #20

Open
evanw555 opened this issue Feb 27, 2020 · 3 comments
Open

Silent failure during Install step #20

evanw555 opened this issue Feb 27, 2020 · 3 comments

Comments

@evanw555
Copy link

It appears that everything is being installed correctly, but the process aborts after this step. It doesn't even get to the Jekyll build step. There are no error logs, so I have no idea what's wrong here. Anyone have any idea?

2020-02-27T22:21:36.5807185Z HEAD is now at 4428e539 Bundle using 1.14.6
2020-02-27T22:21:36.5820884Z Removed matchers: 'checkout-git'
2020-02-27T22:21:36.6039232Z ##[group]Run BryanSchuetz/jekyll-deploy-gh-pages@master
2020-02-27T22:21:36.6039368Z env:
2020-02-27T22:21:36.6039955Z   GITHUB_TOKEN: ***
2020-02-27T22:21:36.6040058Z   GITHUB_REPOSITORY: 
2020-02-27T22:21:36.6040153Z   GITHUB_ACTOR: 
2020-02-27T22:21:36.6040244Z ##[endgroup]
2020-02-27T22:21:36.6065441Z ##[command]/usr/bin/docker run (DOCKER ARGS OMITTED FOR BREVITY)
2020-02-27T22:21:37.1319926Z � ENTRYPOINT HAS STARTED—INSTALLING THE GEM BUNDLE
2020-02-27T22:21:39.3714604Z Fetching gem metadata from https://rubygems.org/............
2020-02-27T22:21:39.6467816Z Fetching version metadata from https://rubygems.org/..
2020-02-27T22:21:39.7032722Z Fetching dependency metadata from https://rubygems.org/.
2020-02-27T22:21:39.8612010Z Installing ffi 1.12.2 with native extensions
2020-02-27T22:21:46.1541339Z Installing rb-fsevent 0.10.3
2020-02-27T22:21:46.2277363Z Installing kramdown 2.1.0
2020-02-27T22:21:46.4561775Z Installing rouge 3.16.0
2020-02-27T22:21:46.5653402Z Using bundler 1.14.6
2020-02-27T22:21:46.6035725Z Installing rb-inotify 0.10.1
2020-02-27T22:21:46.6462226Z Installing kramdown-parser-gfm 1.1.0
2020-02-27T22:21:46.6965174Z Installing listen 3.2.1
2020-02-27T22:21:46.7432230Z Installing jekyll-watch 2.2.1
2020-02-27T22:21:46.7646325Z Bundle complete! 3 Gemfile dependencies, 9 gems now installed.
2020-02-27T22:21:46.7662610Z Bundled gems are installed into /usr/local/bundle.
2020-02-27T22:21:48.0032862Z Cleaning up orphan processes
@evanw555
Copy link
Author

Just realized that this is failing because the bundle list | grep 'jekyll (' check is failing. The problem is that this is silent. You should make this more explicit, like echoing a message saying that jekyll is missing.

@BryanSchuetz
Copy link
Owner

I agree that it shouldn't fail silently. Though if you're not installing Jekyll, the rest of the workflow is still going to fail.

@evanw555
Copy link
Author

Agreed, however this check is arguably a worse user experience because there's no message at all telling you that the Jekyll dependency is missing. Whereas without the check, at least you'd likely see some sort of build failure saying that Jekyll is missing (I'm assuming).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants