don't treat non-text files as text in git line ending conversion #864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artoonie
force-pushed
the
feature/issue-863_cloned-line-endings
branch
from
dba1849
to
fa08b43
Compare
|
I checked it on Windows. It looks good to me.
|
|
I also checked it out on MacOS. It looked good there, too. |
|
Will this cause any issues with the golden hash? |
No, according to Armin here #863 (comment) |
tarheel
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #863
I tested by cloning a fresh repo with just this branch and no files came back dirty. May be worth testing on windows too, but I don't currently have access to a Windows machine. You can test it by:
git clone -b feature/issue-863_cloned-line-endings https://github.com/BrightSpots/rcv