Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/Clean Up Development Builds #862

Open
nurse-the-code opened this issue Jul 1, 2024 · 5 comments · May be fixed by #860
Open

Fix/Clean Up Development Builds #862

nurse-the-code opened this issue Jul 1, 2024 · 5 comments · May be fixed by #860
Assignees

Comments

@nurse-the-code
Copy link
Collaborator

We recently updated the development builds to specify which CPU architecture is being used. It appears that resulted in two problems:

  1. We have files from multiple fortnightly development builds in the same release section. (see the attached screen shot). After talking with @artoonie, it sounds like when creating a fortnightly build, we should delete the old fortnightly build files.
  2. We stopped generating .sha512 files for the executable installers (.deb, .dmg, .exe) when we started generating the .golden.sha512 for the .zip files. Let's add those back in.
Screenshot 2024-06-28 at 12 37 52
@nurse-the-code
Copy link
Collaborator Author

nurse-the-code commented Jul 3, 2024

@artoonie partially fixed the first part by deleting the old build files. It looks like we still have old .zip and .tar.gz files from May 31st.

But the second part still does not appear to be fixed:

We stopped generating .sha512 files for the executable installers (.deb, .dmg, .exe) when we started generating the .golden.sha512 for the .zip files. Let's add those back in.

Finally, while most of the build files say 2 days ago (from the most recent fortnightly build), the header for some reason says "May 31" and the description text says that it is a build of changes "as of June 2nd". Can we fix that too?

Screenshot 2024-07-03 at 14 43 49

@artoonie artoonie linked a pull request Jul 3, 2024 that will close this issue
@artoonie
Copy link
Collaborator

artoonie commented Jul 3, 2024

I have fixed both of those in PR #860

Note that there are additional files in the "Package", which is separate from the "Release": https://github.com/BrightSpots/rcv/actions/runs/9744047355

The package is 700mb and contains every cache file for every OS we support. I believe it was an intentional decision to not include these files in the release, since they're only useful for airgapped builds, but cannot be sure. @yezr do you recall why we decided to have some files in the "Package" not included in the "Release"?

Also -- we should document this in the wiki since I forgot about it!

@yezr
Copy link
Collaborator

yezr commented Jul 3, 2024

I cannot remember why we would leave out the airgap caches. I think we were just scrambling to get it out for that certification and overlooked adding it to the official release?

@artoonie
Copy link
Collaborator

artoonie commented Jul 3, 2024

Alright, I've added all cache files back in. I personally find this much sloppier, since 99% of users don't need the cache files, and this makes it quite hard to find which files are important. I imagine a better naming scheme could help (e.g. all cache files begin with cache_?). Let me know what you think is needed here: https://github.com/BrightSpots/rcv/releases/tag/build-double-develop

@artoonie artoonie self-assigned this Jul 3, 2024
@yezr
Copy link
Collaborator

yezr commented Jul 8, 2024

So the cache files are always created and are part of the build Package? I imagine that for any user who needs an airgapped build that we would be personally involved. In that case, we can always provide them the cache and it wouldn't be required to be a part of the build artifacts.

To make the release a little cleaner, and maybe prevent confusion, I'm fine with not making those an explicit part of the release but leave them in the Package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Review
Development

Successfully merging a pull request may close this issue.

3 participants