Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Avoid re-reading CVRs during 'Tabulate' step of validation modal #839

Open
yezr opened this issue Jun 6, 2024 · 1 comment
Open
Labels

Comments

@yezr
Copy link
Collaborator

yezr commented Jun 6, 2024

As described by @artoonie in this comment on #679, we currently read the CVRs twice: once to get the total number of ballots for the validation modal and again during the Tabulation. Let's think about how to avoid doing that.

Some things to think about....

  • Multi-winner IRV currently reads the CVRs in for each round, excluding the winner of the previous "contest." This will need to be addressed.
  • We should use LoadedCvrMetadata to store hashes of the files and confirm during runtime that the CVRs haven't changed since they were used to get the ballot count. If they have been changed, we should require re-running the ballot count.
@HEdingfield
Copy link
Contributor

Discussed a bit in this PR comment thread.

@yezr yezr added the WIP label Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants