Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Think about how to estimate tasks that run after round by round tabulation and include them in progress bar #836

Open
yezr opened this issue Jun 4, 2024 · 2 comments

Comments

@yezr
Copy link
Collaborator

yezr commented Jun 4, 2024

check out these three tickets for context #679 #133 and especially #825 which needs to be implemented first.

Once #825 is complete we need to review how to include the two optional post-tabulation tasks that can take time: tabulate by precinct and tabulate by batch. How can we estimate the time they will take and include it in our granular progress bar?

Just thinking out loud with my current understanding of the code: I think that they will probably be very very quick, quicker than a single round of tabulation. The per-round tallies are computed and saved in memory during each round of tabulation. The actual writing to disk just does some small translation from the in-memory representation into a file.

@yezr
Copy link
Collaborator Author

yezr commented Jun 25, 2024

check armin's comments here this takes so little time that it's basically inconsequential to the progress bar

@artoonie
Copy link
Collaborator

Additionally: tabulate-by-X occurs during tabulation, and is therefore already included in the progress bar.

The only piece that's not is writing out the results files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

2 participants