Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking '+' in Water Chemistry tool terminates the application with an assert #819

Open
matty0ung opened this issue Sep 3, 2024 · 0 comments

Comments

@matty0ung
Copy link
Contributor

matty0ung commented Sep 3, 2024

Last few log lines:

[18:23:36.485] (17yk386z28) DEBUG : void TableModelBase<Derived, NE>::add(std::shared_ptr<_Tp>) [with Derived = RecipeAdjustmentSaltTableModel; NE = RecipeAdjustmentSalt] ""  [tableModels/TableModelBase.h:289]
[18:23:36.485] (17yk386z28) DEBUG : Recipe* TableModelBase<Derived, NE>::doGetObservedRecipe() const requires (IsTableModel<Caller>) && (ObservesRecipe<Caller>) [with Caller = RecipeAdjustmentSaltTableModel; Derived = RecipeAdjustmentSaltTableModel; NE = RecipeAdjustmentSalt] Substantive version  [tableModels/TableModelBase.h:373]
[18:23:36.485] (17yk386z28) WARNING : Salt* RecipeAdjustmentSalt::salt() const No Salt set on RecipeAdjustmentSalt # -1  [model/RecipeAdjustmentSalt.cpp:97]
[18:23:36.485] (17yk386z28) DEBUG : QVariant PropertyPath::getValue(const NamedEntity&) const Property salt returned nullptr  [utils/PropertyPath.cpp:179]
[18:23:36.485] (17yk386z28) ERROR : QVariant TableModelBase<Derived, NE>::readDataFromModel(const QModelIndex&, int) const [with Derived = RecipeAdjustmentSaltTableModel; NE = RecipeAdjustmentSalt] Unable to read RecipeAdjustmentSalt # -1 property "salt/name" (Got QVariant(Invalid) )  [tableModels/TableModelBase.h:507]
[18:23:36.485] (17yk386z28) ERROR : ASSERT: "false" in file ../src/tableModels/TableModelBase.h, line 510  [tableModels/TableModelBase.h:510]
Abandon (core dumped)

I know where to start looking for this, but it's a slightly different bug from the ones in #817, so giving it its own issue.

Part of the issue is that we have not previously managed salts in quite the same way as other ingredients. Now that we've more closely aligned how recipe additions work, we need to create a bit of extra logic for creating and managing salts in the same way as fermentables, hops, misc items etc. It will then be more straightforward to get salt additions to work. (This is the plan, anyway.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant