Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REQ: Full Functional Yeast Supplement #731

Open
Jazzbeerman opened this issue Mar 9, 2023 · 2 comments
Open

REQ: Full Functional Yeast Supplement #731

Jazzbeerman opened this issue Mar 9, 2023 · 2 comments

Comments

@Jazzbeerman
Copy link

Hello! I ran into one minor problem. When adding your own entry in the "yeast" category, there is no amount window, which makes it impossible to specify the size of the yeast package. In particular, there is no Mangrove Jack's in the database. I was able to add an extra row to the database using beerXML, but this method is not obvious. (Well, at least it looks strange, with a new button that can add yeast). It would be cool if this was fixed)

@matty0ung
Copy link
Contributor

Oh, yes, I see what you mean! That should be relatively straightforward to add since, as you say, the field exists in the DB.

If nobody else gets there first, I'll add this back in when I do the new BeerJSON fields for yeast. (Have done Hops and am working on Fermentable at the moment...)

@matty0ung
Copy link
Contributor

Sorry for delay in coming back on this.

Having had a closer look, I don't think there is as straightforward way as we thought to store size of yeast package.

In the BeerXML world, the amount field (which used to be stored in the yeast table) is, depending on the context, either the total amount in your inventory or the amount being added to a particular recipe. With the introduction of BeerJSON, these are now stored separately in the amount column of the yeast_in_inventory and yeast_in_recipe tables. The amount, both for inventory and recipe additions, can be measured in:

  • weight
  • volume
  • number of packets

I need to fix a bug with the last of these, but it's the next thing I'm working on!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants