html output incomplete

[bernt-matthias]

seems that the html report written by parseval is incomplete. closing </div>, </body> and </html> tags are missing. While the pages are still rendered nicely in the browser I guess its still worth to fix:

AEGeAn/src/core/AgnCompareReportHTML.c

Line 401 in 4d59d2f

static void compare_report_html_footer(FILE *outstream)

[gallardoalba]

Nice, let me fix it.

[standage]

There is no </body> in the HTML output? Were there any relevant warning messages in the terminal? The functions that call compare_report_html_footer print the closing tags, e.g.:

AEGeAn/src/core/AgnCompareReportHTML.c

Lines 564 to 569 in 4d59d2f

	compare_report_html_footer(outstream);
	fputs(" </div>\n"
	" </body>\n"
	"</html>",
	outstream);
	fclose(outstream);

[bernt-matthias]

There is no </body> in the HTML output?

Exactly.

I think parseval uses this code:

AEGeAn/src/core/AgnCompareReportHTML.c

Line 232 in 4d59d2f

compare_report_html_footer(outstream);

I do not see relevant warning messages, only:

warning: line 1 in file "/tmp/tmpgrh_etn9/files/f/5/e/dataset_f5eef5a3-9978-4259-80d2-0ce1f458c407.dat" does not begin with "##gff-version" or "##gvf-version", create "##gff-version 3" line automatically
warning: illegal uppercase attribute "Index" on line 3 in file "/tmp/tmpgrh_etn9/files/f/5/e/dataset_f5eef5a3-9978-4259-80d2-0ce1f458c407.dat"; change to lowercase
warning: illegal uppercase attribute "Index" on line 20 in file "/tmp/tmpgrh_etn9/files/f/5/e/dataset_f5eef5a3-9978-4259-80d2-0ce1f458c407.dat"; change to lowercase
warning: illegal uppercase attribute "Index" on line 44 in file "/tmp/tmpgrh_etn9/files/f/5/e/dataset_f5eef5a3-9978-4259-80d2-0ce1f458c407.dat"; change to lowercase
warning: illegal uppercase attribute "Index" on line 65 in file "/tmp/tmpgrh_etn9/files/f/5/e/dataset_f5eef5a3-9978-4259-80d2-0ce1f458c407.dat"; change to lowercase
warning: illegal uppercase attribute "Index" on line 74 in file "/tmp/tmpgrh_etn9/files/f/5/e/dataset_f5eef5a3-9978-4259-80d2-0ce1f458c407.dat"; change to lowercase
warning: seqid "Chr1" on line 1 in file "/tmp/tmpgrh_etn9/files/f/5/e/dataset_f5eef5a3-9978-4259-80d2-0ce1f458c407.dat" has not been previously introduced with a "##sequence-region" line, create such a line automatically
warning: line 1 in file "/tmp/tmpgrh_etn9/files/4/b/f/dataset_4bf3f971-5128-4f0e-b687-5eb62b62fb27.dat" does not begin with "##gff-version" or "##gvf-version", create "##gff-version 3" line automatically
warning: illegal uppercase attribute "Index" on line 3 in file "/tmp/tmpgrh_etn9/files/4/b/f/dataset_4bf3f971-5128-4f0e-b687-5eb62b62fb27.dat"; change to lowercase
warning: illegal uppercase attribute "Index" on line 20 in file "/tmp/tmpgrh_etn9/files/4/b/f/dataset_4bf3f971-5128-4f0e-b687-5eb62b62fb27.dat"; change to lowercase
warning: illegal uppercase attribute "Index" on line 44 in file "/tmp/tmpgrh_etn9/files/4/b/f/dataset_4bf3f971-5128-4f0e-b687-5eb62b62fb27.dat"; change to lowercase
warning: illegal uppercase attribute "Index" on line 65 in file "/tmp/tmpgrh_etn9/files/4/b/f/dataset_4bf3f971-5128-4f0e-b687-5eb62b62fb27.dat"; change to lowercase
warning: illegal uppercase attribute "Index" on line 74 in file "/tmp/tmpgrh_etn9/files/4/b/f/dataset_4bf3f971-5128-4f0e-b687-5eb62b62fb27.dat"; change to lowercase
warning: seqid "Chr1" on line 1 in file "/tmp/tmpgrh_etn9/files/4/b/f/dataset_4bf3f971-5128-4f0e-b687-5eb62b62fb27.dat" has not been previously introduced with a "##sequence-region" line, create such a line automatically

[standage]

Got it. Yes, it looks like closing </body> and </html> tags are indeed missing from the agn_compare_report_html_create_summary function.