Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Challenges / Sponsorings #183

Open
florianschmidt1994 opened this issue Dec 21, 2016 · 1 comment
Open

Refactor Challenges / Sponsorings #183

florianschmidt1994 opened this issue Dec 21, 2016 · 1 comment
Milestone
Model Refactoring

Comments

@florianschmidt1994
Copy link
Member

florianschmidt1994 commented Dec 21, 2016 •
edited
Loading

Challenges & Sponsorings should be refactored. Proposed idea:
img_6525
Everything is an abstract Challenge, where each implementation is a different variation of the challenges that are available in our system (e.g. OnetimeChallenge, RepeatingChallenge, DistanceChallenge)
Also, UnregisteredSponsors are more loosely coupled, as both UnregisteredSponsor and Sponsor implement the ISponsor Interface
@florianschmidt1994 florianschmidt1994 added this to the Model Refactoring milestone Dec 21, 2016
@tgraupne
Copy link
Member

tgraupne commented Jan 4, 2017

@florianschmidt1994 What do you think about splitting this into two issues since both refactoring are quite complex?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Model Refactoring
Development

No branches or pull requests
2 participants
@florianschmidt1994 @tgraupne