Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding members to database on startup is horribly and needlessly inefficient #3

Open
Brayzure opened this issue Apr 16, 2017 · 0 comments

Comments

@Brayzure
Copy link
Owner

To test initial functionality, the client attempts to add every single member it sees to the database all over again. Initially, the database handled conflicts by ignoring the provided data, which meant that performance was acceptable. However, now that conflicts are resolved by pushing the member's join date to the join_dates array, there is a very real performance hit (close to 3 minutes for 200k+ members), during which time the database is unusable. As soon as feasible, this needs to be resolved. Potentially need to pull all member and guild IDs, then check against that list before we ask the database to insert another row, or update an existing one.

@Brayzure Brayzure changed the title Adding members to database is horribly and needlessly inefficient Adding members to database on startup is horribly and needlessly inefficient Apr 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant