Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add a ConfigManager class #60

Open
sarthakpati opened this issue Mar 31, 2024 · 0 comments
Open

[Feature] Add a ConfigManager class #60

sarthakpati opened this issue Mar 31, 2024 · 0 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@sarthakpati
Copy link
Collaborator

sarthakpati commented Mar 31, 2024

Is your feature request related to a problem? Please describe.
Currently, the defaults for all keys are dictated in the RegistrationClass, which can be problematic since there is no "single source of truth".

Describe the solution you'd like
A ConfigManager class, which resides in ereg.configurations would be the appropriate solution. See #59 (comment) for details. The ConfigManager class should read in default parameter values from the sample config, and then we over-write them based on the new one passed by the user.

Describe alternatives you've considered
N.A.

Additional context
N.A.

@neuronflow neuronflow added the enhancement New feature or request label Mar 31, 2024
@sarthakpati sarthakpati added the help wanted Extra attention is needed label Mar 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants