Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configf: add multiple index (unsigned int) read method. #142

Open
stuart-knock opened this issue Jan 30, 2018 · 0 comments
Open

Configf: add multiple index (unsigned int) read method. #142

stuart-knock opened this issue Jan 30, 2018 · 0 comments

Comments

@stuart-knock
Copy link
Member

A limitation of Configf is that it has only one member function, numbers(), for reading multiple numbers(vector or array) from a configuration file. This member returns a vector of doubles, which causes problems with type specification when what we are reading are indices (eg, node index to apply stimulus to).

This should be corrected. Probably best to start by renaming numbers() to something more specific like read_doubles() and adding a new member function for reading and returning unsigned int like size_type.

Only two should be required as indices(size_type) and doubles are the only type of content we specify in vectors...

Once done, the remaining instances of indices being declared as double instead of size_type can be corrected.

@stuart-knock stuart-knock self-assigned this Jan 30, 2018
@stuart-knock stuart-knock added this to the TBD 1 milestone Feb 9, 2018
@stuart-knock stuart-knock removed their assignment Sep 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant