Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Framework for GobanView #7

Open
Abizern opened this issue Feb 12, 2019 · 2 comments
Open

Create Framework for GobanView #7

Abizern opened this issue Feb 12, 2019 · 2 comments
Assignees
Labels

Comments

@Abizern
Copy link
Contributor

Abizern commented Feb 12, 2019

More of a question about direction rather than an Issue - I'm just checking that this is somewhere you wish for the project to go before I do the work on raising a PR request.

Currently this project just builds the Sample application with the code for the view and the parser included as part of this project. My proposal is to add a framework project to the repository that contains the view and the parser code that the sample project uses.

Eventually - move the sample project into it's own repository and refactor Goban view so that it can be used to create iOS and macOS specific Frameworks.

@Boris-Em Boris-Em self-assigned this Feb 12, 2019
@Boris-Em
Copy link
Owner

Yep, that's what I had in mind as well.
One thing to note though is that I'd like to see 2 frameworks. One for GobanView and one for GobanManager. We should be able to use one without the other.

@Abizern
Copy link
Contributor Author

Abizern commented Feb 12, 2019

Seems reasonable. I'll have another look at the code. I think it's a good idea to separate the management of the view from the actual display of the view. That way the common code stays in the manager and then the actual iOS and macOS views can be separate.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants