Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support tag classes in export formats #5479

Open
DoctorRetromaker opened this issue Feb 9, 2025 · 0 comments
Open

Support tag classes in export formats #5479

DoctorRetromaker opened this issue Feb 9, 2025 · 0 comments

Comments

@DoctorRetromaker
Copy link

Describe the Bug

When exporting «books», «chapters» or «pages», appended tags to any of them aren't exported in the resulting «Contained Web File».

Isn't tested in other export options, but there is no reason to expect different behavior.

This is inconsistent with the «tags hacking proposal», because any CSS styles based on «tags» correctly working on standard view, will fail in the exported «contained html».

Steps to Reproduce

  1. Add any «tag» to a «book», «chapter» or «page» ..
  2. Create a custom CSS file including any style applied only with the «tag-css-class»
  3. Create a simple HTML page with any text that include the «tag-css-class» to modify the standard style
  4. Export to «Contained Web File»
  5. ... and «voilà», the «tag-css-class» controlled style don't work, just because the «tags-css-classes» aren't included

Expected Behaviour

All «book», «chapter» or «page» «tag-css-class» should be included in the «Contained Web File» « class» attribute.

If there are repeated tags, only one must be included; it is a user responsibility to design a good «tags hacking» strategy

Screenshots or Additional Context

No response

Browser Details

Brave 1.175.175

Exact BookStack Version

24.12.1

@ssddanbrown ssddanbrown changed the title «tags» aren't included when exporting books, chapters or pages Support tag classes in export formats Feb 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants