Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error handling of synchronous notifications #5315

Open
ssddanbrown opened this issue Nov 11, 2024 · 0 comments
Open

Improve error handling of synchronous notifications #5315

ssddanbrown opened this issue Nov 11, 2024 · 0 comments

Comments

@ssddanbrown
Copy link
Member

ssddanbrown commented Nov 11, 2024

Notification email sending failures, without using a queue/worker currently throw and block the process, showing the error view.
Since email requires the network, and SMTP servers can respond in various unexpected ways, and since notifications sending issues probably wouldn't be considered an essential error to the majority of cases, would should probably instead attempt these but catch & log errors, to allow the action within BookStack to continue as expected.

Related to support thread 125

Doc Updates

Probably worth documenting error behaviour on the docs page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

1 participant