Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove sdk publication workflows (or document their purpose) #356

Open
demeringo opened this issue Dec 12, 2024 · 9 comments
Open

Remove sdk publication workflows (or document their purpose) #356

demeringo opened this issue Dec 12, 2024 · 9 comments

Comments

@demeringo
Copy link
Collaborator

demeringo commented Dec 12, 2024

Problem

We have 2 workflows (github actions) that are related to publishing a SDK for the API.

Not sure if they still have any purpose today.

Solution

Remove theses 2 workflows if they are not used anymore or document their purpose.

Alternatives

Additional context or elements

These workflow do not seem to work anyway: https://github.com/Boavizta/boaviztapi/actions/workflows/build_client_sdk_with_poetry.yml

@da-ekchajzer
Copy link
Collaborator

Done

@da-ekchajzer
Copy link
Collaborator

da-ekchajzer commented Dec 13, 2024

Is there a way to say that the project (Python sdk) is not maintained in pypi?

@demeringo
Copy link
Collaborator Author

From what I have seen, there is no way of deprecate a project (on going discussion here: https://discuss.python.org/t/adding-a-mechanism-to-deprecate-a-published-project/13937/13) and an open PR here: pypi/warehouse#17005

For the time being an option is to update the description in pypi to mention the deprecation.

@demeringo
Copy link
Collaborator Author

demeringo commented Dec 13, 2024

For reference, workflow deleted in d75b34c
and
577d0c0

@bdromard
Copy link
Contributor

bdromard commented Dec 17, 2024

Hi!

Boagent was relying so far on up-to-date versions of the SDK for its interactions with BoaviztAPI (mainly through the generated ServerApi and Server classes).
Am I understanding correctly that the Python SDK for BoaviztAPI will not be automatically generated anymore?
I could look into why those workflows were not working at some point and task myself with fixing them, it that's all right with you!

@da-ekchajzer
Copy link
Collaborator

Oups. It has been deleted...

If you can try to fix it go for it !

Latest version before deletion : https://github.com/Boavizta/boaviztapi/blob/v1.3.7/.github/workflows/build_client_sdk_with_poetry.yml

@demeringo
Copy link
Collaborator Author

demeringo commented Dec 20, 2024

@bdromard, sorry we did not identify that this workflow was still in use.

If you are ok this this, I create a dedicated issue to re-enable it and we can close this one.

@demeringo
Copy link
Collaborator Author

demeringo commented Dec 20, 2024

Created #362

@bdromard
Copy link
Contributor

Fine with me, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants