From 019d0a29f7b1de932fcaae54996ce5dd90b96bd0 Mon Sep 17 00:00:00 2001 From: androda <3105206+androda@users.noreply.github.com> Date: Fri, 13 Sep 2024 08:27:34 -0600 Subject: [PATCH] Remove comment, tested removing CMD16 on SDHC cards and it didn't work --- lib/BlueSCSI_platform_RP2040/sd_card_sdio.cpp | 3 --- 1 file changed, 3 deletions(-) diff --git a/lib/BlueSCSI_platform_RP2040/sd_card_sdio.cpp b/lib/BlueSCSI_platform_RP2040/sd_card_sdio.cpp index 81c71200..bb9dc328 100644 --- a/lib/BlueSCSI_platform_RP2040/sd_card_sdio.cpp +++ b/lib/BlueSCSI_platform_RP2040/sd_card_sdio.cpp @@ -425,9 +425,6 @@ bool SdioCard::readSector(uint32_t sector, uint8_t* dst) uint32_t address = (type() == SD_CARD_TYPE_SDHC) ? sector : (sector * 512); uint32_t reply; - // Honestly CMD16 feels partially unnecessary. Default block length is 512. SDHC, SDXC, SDUC, *always* use 512 and this does nothing. - // Set length is valid for memory access commands only if partial block read operation are allowed in CSD. - // We do have the CSD, so CMD16 should only be run if actually necessary if ( !checkReturnOk(rp2040_sdio_command_R1(16, 512, &reply)) || // SET_BLOCKLEN !checkReturnOk(rp2040_sdio_command_R1(CMD17, address, &reply)) || // READ_SINGLE_BLOCK