Skip to content

Commit b73dca6

Browse files
committed
Fix fs store test patching & creating directories
1 parent 41df98c commit b73dca6

File tree

1 file changed

+5
-2
lines changed

1 file changed

+5
-2
lines changed

tests/test_store_creation.py

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -112,6 +112,7 @@ def test_create_store_s3(mocker):
112112

113113
def test_create_store_hfs(mocker):
114114
mock_hfs = mocker.patch("storefact._hstores.HFilesystemStore")
115+
mock_makedirs = mocker.patch("os.makedirs")
115116
create_store(
116117
"hfs",
117118
{
@@ -121,11 +122,12 @@ def test_create_store_hfs(mocker):
121122
},
122123
)
123124
mock_hfs.assert_called_once_with('this/is/a/relative/path')
125+
mock_makedirs.assert_called_once_with('this/is/a/relative/path')
124126

125127

126-
@pytest.mark.skip(reason="some issue here")
127128
def test_create_store_fs(mocker):
128-
mock_fs = mocker.patch("simplekv.fs.FilesystemStore")
129+
mock_fs = mocker.patch("storefact._store_creation.FilesystemStore")
130+
mock_makedirs = mocker.patch("os.makedirs")
129131
create_store(
130132
"fs",
131133
{
@@ -135,6 +137,7 @@ def test_create_store_fs(mocker):
135137
}
136138
)
137139
mock_fs.assert_called_once_with('this/is/a/relative/fspath')
140+
mock_makedirs.assert_called_once_with('this/is/a/relative/fspath')
138141

139142

140143
def test_create_store_mem(mocker):

0 commit comments

Comments
 (0)