Skip to content

Nested witness signature path injection#45

Merged
Arvolear merged 8 commits intoBlockstreamResearch:devfrom
topologoanatom:nested-sig-path
Apr 17, 2026
Merged

Nested witness signature path injection#45
Arvolear merged 8 commits intoBlockstreamResearch:devfrom
topologoanatom:nested-sig-path

Conversation

@topologoanatom
Copy link
Copy Markdown
Contributor

Changes

Added functionality to inject signature value from RequiredSignature into nested match blocks.

@topologoanatom topologoanatom marked this pull request as ready for review April 8, 2026 08:29
@topologoanatom topologoanatom requested a review from Arvolear as a code owner April 8, 2026 08:29
Comment thread crates/sdk/src/signer/core.rs Outdated
Comment thread crates/sdk/src/signer/core.rs Outdated
Comment thread examples/basic/tests/nested_sig.rs
Comment thread crates/sdk/src/signer/core.rs Outdated
Comment thread examples/basic/tests/nested_sig.rs Outdated
@topologoanatom topologoanatom marked this pull request as draft April 9, 2026 12:35
@topologoanatom topologoanatom marked this pull request as ready for review April 13, 2026 07:00
@topologoanatom topologoanatom requested a review from Arvolear April 16, 2026 07:12
Copy link
Copy Markdown
Collaborator

@Arvolear Arvolear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Arvolear Arvolear merged commit 4bff33e into BlockstreamResearch:dev Apr 17, 2026
7 checks passed
@topologoanatom topologoanatom deleted the nested-sig-path branch April 20, 2026 08:06
Arvolear added a commit that referenced this pull request Apr 23, 2026
* generate a new block in the end of prepare_signer() (#44)

* Sdk unit tests (#43)

* unit tests for `extract_pst`

* unit test for program's `get_env()`

* quick cleanup

---------

Co-authored-by: Artem Chystiakov <artem.ch31@gmail.com>

* Add basic storage support (#46)

* Add basic ProgramStorage implementation

* Remove unnecessary ProgramStorage struct

* Rename set function

* Fix example

* Feat/reissuance (#50)

* reissuance support

* reissuance interface fix

* Nested witness signature path injection (#45)

* add nested sig parser

* wip: add support for tuple and array paths

* wip: store changes

* fix tests and few docs

* refactor injecting functions into structure

* add either consistency check and unit tests

* refactor

---------

Co-authored-by: Artem Chystiakov <artem.ch31@gmail.com>

* Add `RequiredSignature` constructor  (#52)

* add constructor to improve test readability

* submit review suggestion

* add the auth and ports config support for the project manifest (#54)

* smplx-build: fix witness type conversion in single-valued either type (#51)

* smplx-build: fix witness type conversion in single-valued either type

* add one more contract to ui tests

* smplx-build: add support for u1, u2, u4 and List types

* add additional test cases
* add line breaks at the end of the *.simf files

* smplx-build: remove duplicated logic and functions

* functions:
generate_inline_array_element_extraction(), generate_inline_list_element_extraction(), generate_inline_tuple_element_extraction(), generate_inline_either_extraction()
* duplicated logic in generate_from_value_extraction()

* typos: add delimiters

* Tiny functions (#57)

* some tiny functions

* allow sad flow tests

* metadata output

* fix: `simplex test` runs non-simplex test when no args provided (#56)

* invoke smplx tests by suffix when no args provided

* separate name filtering and integration tests

* refactor

---------

Co-authored-by: Artem Chystiakov <artem.ch31@gmail.com>

* changelog

* version

---------

Co-authored-by: Ruslan Kasheparov <55411970+RuslanProgrammer@users.noreply.github.com>
Co-authored-by: Vitaliy Volovyk <161724671+topologoanatom@users.noreply.github.com>
Co-authored-by: Oleh Komendant <44612825+Hrom131@users.noreply.github.com>
Co-authored-by: Ivan Lele <110336129+ivanlele@users.noreply.github.com>
Co-authored-by: Illia Kripaka <30872146+ikripaka@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants