Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

builddeps.sh refers to dead Boost 1.84.0 download link #216

Closed
h4vismat opened this issue Jan 8, 2025 · 2 comments
Closed

builddeps.sh refers to dead Boost 1.84.0 download link #216

h4vismat opened this issue Jan 8, 2025 · 2 comments

Comments

@h4vismat
Copy link

h4vismat commented Jan 8, 2025

The current bash script that downloads dependencies downloads Boost 1.84.0 from https://boostorg.jfrog.io/artifactory/main/release/1.84.0/source/boost_1_84_0.tar.gz, which redirects to https://landing.jfrog.com/reactivate-server/boostorg. The correct file is then not downloaded, and so build fails. See an example below of a Docker image build.

70.85 downloading from https://boostorg.jfrog.io/artifactory/main/release/1.84.0/source/boost_1_84_0.tar.gz ...
72.93 checking boost_1_84_0.tar.gz...
72.95 shasum: WARNING: 1 computed checksum did NOT match
72.95 boost_1_84_0.tar.gz: FAILED
------

 3 warnings found (use docker --debug to expand):
 - FromAsCasing: 'as' and 'FROM' keywords' casing do not match (line 4)
 - FromAsCasing: 'as' and 'FROM' keywords' casing do not match (line 19)
 - FromAsCasing: 'as' and 'FROM' keywords' casing do not match (line 21)
Dockerfile:17
--------------------
  15 |     FROM base AS builderlinux
  16 |     #wally absolutely wants a running python -- it doesn't really matter the version here
  17 | >>> RUN source /opt/python/default/bin/activate && ./tools/builddeps.sh --clang --prefix /prebuild/clang
  18 |
  19 |     FROM rust:1.71-bullseye as builderrust
--------------------
ERROR: failed to solve: process "/bin/sh -c source /opt/python/default/bin/activate && ./tools/builddeps.sh --clang --prefix /prebuild/clang" did not complete successfully: exit code: 1

Boost 1.84.0 is now hosted on https://archives.boost.io/release/1.84.0/source/boost_1_84_0.tar.gz, and so the builddeps.sh file should be updated to refer to this new URL.

@jgriffiths
Copy link
Contributor

Thanks @h4vismat I'll fix this shortly.

@jgriffiths
Copy link
Contributor

Fixed in master, thanks again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants