Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

0.73.3 Candidate #211

Merged
merged 3 commits into from
Oct 24, 2024
Merged

0.73.3 Candidate #211

merged 3 commits into from
Oct 24, 2024

Conversation

jgriffiths
Copy link
Contributor

@jgriffiths jgriffiths commented Oct 18, 2024 •
edited
Loading

Added

  • GA_create_redeposit_transaction: Add support for "expired_at" to create re-deposit transactions for UTXOs that will expire in the future.
  • GA_get_balance/GA_get_unspent_outputs/GA_create_redeposit_transaction: Add support for "expires_in" to support filtering for UTXOs that expire in the given number of blocks from the current block height.

Changed

  • Transactions: Improve error messages when too many or duplicate inputs are used.

Fixed

  • Transactions: Fix weight calculation for Liquid when all inputs to a transaction are non-segwit (i.e. p2sh, p2pkh). This fix prevents the actual fee rate from becoming lower than the desired fee rate.
  • Singlesig(Liquid): Prevent returned fee rates from falling below the networks real relay fee rate of 0.1 sat/vbyte.

Fixes #210

@jgriffiths jgriffiths mentioned this pull request Oct 18, 2024
Closed
@jgriffiths jgriffiths force-pushed the minor_tweaks branch 2 times, most recently from b36b751 to cafbc7e Compare October 22, 2024 19:48
@jgriffiths
tx: remove calculated_fee_rate if no fee is present
6e8632b 
This ensures that the calculated fee is either correct or not present
(e.g. if the JSON is manipulated and re-submitted without a fee).
@jgriffiths
rust: ensure that the minimum fee rate does not fall below the default
cedc592 
Mainnet Liquid is currently configured to return relay fees that are
too low, in order to work around a bug with older elementsd instances.

This ensures that users don't attempt to use the too-low fee.
@RCasatta RCasatta changed the title 0.7.3 Candidate 0.77.3 Candidate Oct 24, 2024
@RCasatta RCasatta changed the title 0.77.3 Candidate 0.73.3 Candidate Oct 24, 2024
@jgriffiths jgriffiths merged commit 904e93b into master Oct 24, 2024
@jgriffiths jgriffiths deleted the minor_tweaks branch October 24, 2024 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

size calculation is wrong for large transactions
1 participant
@jgriffiths