-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GDK 0.68.0 Windows build crashes in GA_connect
#198
Comments
Hi @pavel-kokolemin thanks for the report. Can you confirm if this works for you with an earlier gdk version, and if so what is the last version that works? |
I have tried
So it looks like a regression in |
@pavel-kokolemin can you try branch release_0.68_dev? |
@borgbyte work fine, thanks. |
@pavel-kokolemin fyi 0.68.1 is in pre-release |
Hello @pavel-kokolemin even though we managed to fix your windows issue by reverting some changes, we are still investigating the root cause of the crash. We are having hard times replicating it though. May I ask some questions?
and following As last request,
thanks |
Hi @lightyear15
I'm using Windows 11. The first time the crash was reported by our test user, so I doubt it's related to my Windows installation. And why do other builds work?
No. The crash always happens and I have a good network connection.
I applied the patch and tried 0.68.0 and the latest master branch (commit 5021276) and it still crashes. 0.68.2 works fine as I already reported.
Can you send your libgreenaddress.dll build? Thanks. |
It seems on Windows10 the bug does not pop up. The zip file attached contains the libgreenaddress.dll and the executable result of the build of my version of your main.cpp (the one patched according to comment above + some few more logs) |
I can't reproduce the crash either.
While the GDK build without 52f2b2e commit works normally in all situations. |
Thanks @pavel-kokolemin for your help: I am not sure I understand the situation:
can you give me some insight on what your build instructions are? Thanks |
Hi @lightyear15 I built it as before:
And
Copied gdk_crash.exe, libgreenaddress.dll and these mingw libs (from Debian 12):
I have tried: The same crash happened when I tried mingw from Debian 11. |
can you please do one more round of tests using gdk from this branch? Thanks a lot for your invaluable help in testing and investigating this issue. |
Hi @lightyear15, thank you! I tried this commit and it works a bit better (no crash after the first iteration), but it still crashes after about 10..20 iterations. And I checked |
Hi @pavel-kokolemin , 🤞 🤞 |
@lightyear15 No problem! |
@pavel-kokolemin During the whole process of debugging this issue I managed to reproduce the bug as you were reporting. Thanks a lot again |
I checked again, b7d4e14 crashes after about 10..20 iterations while release_0.68.4 works normally. And I have rebuilt all dependencies in both cases. |
hello @pavel-kokolemin , May I ask you to report a stack trace of the bug?
let me know if you need more detailed explanation or any further help on how to get a stack trace of the bug. Cheers |
Now I can't reproduce the crash either. I guess something was wrong on my end. |
GDK 0.68.0 Windows build crashes in
GA_connect
when used with multi-sig accounts (single-sig accounts work fine).I have reproduced the crash in a minimal program (
main.cpp
).To build:
Copy libgreenaddress.dll and required mingw libs:
Then run the binary (
gdk_crash.exe
):I tried building on Debian 12 and Debian 11, same crash happens.
It works fine on Linux:
main.cpp.txt
The text was updated successfully, but these errors were encountered: