getSettings for DisallowIncoming amendments

Author: ildaruz

package-lock.json

@@ -1,6 +1,6 @@
 {
   "name": "@bithomp/xrpl-api",
-  "version": "2.2.16",
+  "version": "2.2.17",
   "description": "A Bithomp JavaScript/TypeScript library for interacting with the XRP Ledger",
   "main": "lib/index.js",
   "types": "lib/index.d.ts",
@@ -43,17 +43,17 @@
     "@types/chai": "^4.3.4",
     "@types/chai-as-promised": "^7.1.5",
     "@types/mocha": "^10.0.1",
-    "@types/node": "^18.15.5",
+    "@types/node": "^18.15.11",
     "chai": "^4.3.7",
     "chai-as-promised": "^7.1.1",
     "mocha": "^10.2.0",
     "nconf": "^0.12.0",
-    "prettier": "^2.8.5",
-    "ts-jest": "^29.0.5",
+    "prettier": "^2.8.7",
+    "ts-jest": "^29.1.0",
     "ts-node": "^10.9.1",
     "tslint": "^6.1.3",
     "tslint-config-prettier": "^1.18.0",
-    "typescript": "^5.0.2"
+    "typescript": "^5.0.4"
   },
   "files": [
     "lib/**/*"

package.json

@@ -51,12 +51,6 @@ export const FaucetNetworks = {
     url: "https://faucet.devnet.rippletest.net/accounts",
     format: "xrpl",
   },
-  xls20: {
-    // xls20, nft-sandbox, and nft are all the same
-    // https://xls20.bithomp.com
-    url: "https://faucet-nft.ripple.com/accounts",
-    format: "xrpl",
-  },
   hooks: {
     // the same as hooks-v2, hooks-v1 was discontinued
     // https://beta.bithomp.com

src/faucet.ts

@@ -14,6 +14,10 @@ export const AccountRootFlagsKeys = {
   noFreeze: LedgerEntry.AccountRootFlags.lsfNoFreeze,
   globalFreeze: LedgerEntry.AccountRootFlags.lsfGlobalFreeze,
   defaultRipple: LedgerEntry.AccountRootFlags.lsfDefaultRipple,
+  disallowIncomingNFTokenOffer: LedgerEntry.AccountRootFlags.lsfDisallowIncomingNFTokenOffer,
+  disallowIncomingCheck: LedgerEntry.AccountRootFlags.lsfDisallowIncomingCheck,
+  disallowIncomingPayChan: LedgerEntry.AccountRootFlags.lsfDisallowIncomingPayChan,
+  disallowIncomingTrustline: LedgerEntry.AccountRootFlags.lsfDisallowIncomingTrustline,
 };
 
 export interface AccountRootFlagsKeysInterface {
@@ -26,6 +30,10 @@ export interface AccountRootFlagsKeysInterface {
   noFreeze?: boolean;
   globalFreeze?: boolean;
   defaultRipple?: boolean;
+  disallowIncomingNFTokenOffer?: boolean;
+  disallowIncomingCheck?: boolean;
+  disallowIncomingPayChan?: boolean;
+  disallowIncomingTrustline?: boolean;
 }
 
 export const SignerListFlagsKeys = {
@@ -53,7 +61,7 @@ export const AccountFields = {
  *   domain: "test.bithomp.com",
  * }
  */
- export function getSettings(accountInfo: any, excludeFalse: boolean = true): object {
+export function getSettings(accountInfo: any, excludeFalse: boolean = true): object {
   const parsedFlags = parseAccountFlags(accountInfo.Flags, { excludeFalse });
   const parsedFields = parseAccountFields(accountInfo, { excludeFalse });
 

src/models/account_info.ts

@@ -6,7 +6,7 @@ export function parseNFTokenChanges(tx: object): object {
   return new NFTokenChanges(tx).call();
 }
 
-interface AccountNFTockenChangesInterface {
+interface AccountNFTokenChangesInterface {
   status: string;
   nftokenID: string;
   uri?: string;
@@ -50,7 +50,7 @@ class NFTokenChanges {
     return true;
   }
 
-  private addChange(account: string, change: AccountNFTockenChangesInterface): void {
+  private addChange(account: string, change: AccountNFTokenChangesInterface): void {
     if (!this.changes[account]) {
       this.changes[account] = [];
     }

src/models/transaction/nftoken_changes.ts

@@ -157,6 +157,10 @@ describe("Client", () => {
           passwordSpent: false,
           requireAuth: true,
           requireDestTag: false,
+          disallowIncomingCheck: false,
+          disallowIncomingNFTokenOffer: false,
+          disallowIncomingPayChan: false,
+          disallowIncomingTrustline: false,
         });
       });
     });
@@ -202,6 +206,10 @@ describe("Client", () => {
           passwordSpent: true,
           requireAuth: false,
           requireDestTag: false,
+          disallowIncomingCheck: false,
+          disallowIncomingNFTokenOffer: false,
+          disallowIncomingPayChan: false,
+          disallowIncomingTrustline: false,
         });
       });
 
@@ -286,6 +294,10 @@ describe("Client", () => {
           globalFreeze: false,
           defaultRipple: false,
           blackholed: false,
+          disallowIncomingCheck: false,
+          disallowIncomingNFTokenOffer: false,
+          disallowIncomingPayChan: false,
+          disallowIncomingTrustline: false,
         });
       });
     });

test/ledger/account_info.test.ts

@@ -3,48 +3,6 @@ import { expect } from "chai";
 import { Client } from "../../src/index";
 
 describe("Client", () => {
-  describe("xls20", () => {
-    before(async function () {
-      Client.setup(nconf.get("xrpl:connections:xls20net"));
-      await Client.connect();
-    });
-
-    describe("getNftInfo", () => {
-      it("works for active", async function () {
-        const result: any = await Client.getNftInfo("000B0000C124E14881533A9AFE4A5F481795C17003A9FACF0000099B00000000");
-        expect(result).to.eql({
-          nft_id: "000B0000C124E14881533A9AFE4A5F481795C17003A9FACF0000099B00000000",
-          ledger_index: 75217,
-          owner: "rJcEbVWJ7xFjL8J9LsbxBMVSRY2C7DU7rz",
-          is_burned: false,
-          flags: 11,
-          transfer_fee: 0,
-          issuer: "rJcEbVWJ7xFjL8J9LsbxBMVSRY2C7DU7rz",
-          nft_taxon: 0,
-          nft_sequence: 0,
-          uri: "ipfs://QmQjDvDhfHcMyUgDAxKig4AoMTtS5JrsfpiEEpFa3F9QRt",
-          validated: true,
-        });
-      });
-
-      it("works for burned", async function () {
-        const result: any = await Client.getNftInfo("000F0032B6AB2D2C748939F237E1B9ACB589875CB957455E78E2DBCD00000032");
-        expect(result).to.eql({
-          nft_id: "000F0032B6AB2D2C748939F237E1B9ACB589875CB957455E78E2DBCD00000032",
-          ledger_index: 310315,
-          owner: "rUoevHvHkU8H7NN7W4fMRXyz6ipM1TNxDe",
-          is_burned: true,
-          flags: 15,
-          transfer_fee: 50,
-          issuer: "rHe1sToM6nQ37FzrGdC9WWCqJKaaRLscgJ",
-          nft_taxon: 0,
-          nft_sequence: 50,
-          validated: true,
-        });
-      });
-    });
-  });
-
   describe("mainnet", () => {
     before(async function () {
       this.timeout(10000);